[jira] [Created] (VCL-755) Add 'if defined' checks for all get_management_node_info calls

["Andy Kurth (JIRA)" <ji...@apache.org>]

Andy Kurth created VCL-755:
------------------------------

             Summary: Add 'if defined' checks for all get_management_node_info calls
                 Key: VCL-755
                 URL: https://issues.apache.org/jira/browse/VCL-755
             Project: VCL
          Issue Type: Bug
          Components: vcld (backend)
    Affects Versions: 2.3.2
            Reporter: Andy Kurth
             Fix For: 2.4


There are calls to get_management_node_info in utils.pm, DataStructure.pm, and healthcheck.pm which do not check if a defined value is returned such as:
$identity_paths = get_management_node_info()->{keys};

There are cases where get_management_node_info will fail and return null such as if a database connection cannot be obtained.  When this happens and the caller doesn't check for a defined value, the following unhandled error is generated:

Can't use an undefined value as a HASH reference at /usr/local/vcl/bin/../lib/VCL/utils.pm line 4017.

Every line containing "get_management_node_info()->" should be changed to first retrieve the info, then check it, then access the hash reference value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)