You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org> on 2012/03/20 16:13:37 UTC

[jira] [Updated] (BOOKKEEPER-188) Garbage collection code is in the wrong place

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-188:
----------------------------------

    Attachment: BOOKKEEPER-188.diff

This is a very straight forward refactor. The one functional change is that extractMetaFromEntryLogs now call extractMetaFromEntryLog rather than having duplicate logic in each.
                
> Garbage collection code is in the wrong place
> ---------------------------------------------
>
>                 Key: BOOKKEEPER-188
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-188
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-188.diff
>
>
> There's a lot of garbage collection code in the wrong place in EntryLogger. extractMetaFromEntryLogs, and EntryLogMetadata are only every used in the GC Thread. So they should move there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira