You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/29 13:23:43 UTC

[GitHub] [flink] zentol opened a new pull request #10361: [FLINK-14795][tests] Rework TaskExecutorPartitionLifecycleTest

zentol opened a new pull request #10361: [FLINK-14795][tests] Rework TaskExecutorPartitionLifecycleTest
URL: https://github.com/apache/flink/pull/10361
 
 
   This PR pulls apart `TaskExecutorPartitionLifecycleTest` to test interactions between the TE <-> partition tracker, and partition tracker <-> shuffle environment separately.
   
   The current approach is too indirect and not suitable for some tests; particularly when the partition tracker does _something_ but doesn't interact with the shuffle environment.
   
   Several tests in the `TaskExecutorPartitionLifecycleTest` have been removed completely as they test now irrelevant behavior; the TE doesn't care about the partition type as this is an implementation detail of the tracker. Now that we use a test implementation of the tracker this detail has become irrelevant.
   The core structure of the remaining tests has been retained.
   
   The new `TaskExecutorPartitionTrackerImplTest` is a new unit test thats interactions between the tracker and shuffle environment. Specifically it checks under what circumstances partitions are being released.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services