You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/11 03:07:51 UTC
[GitHub] [ozone] JacksonYao287 opened a new pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
JacksonYao287 opened a new pull request #2235:
URL: https://github.com/apache/ozone/pull/2235
## What changes were proposed in this pull request?
now , the rocksdb version used in ozone is 6.8.1, which is build on Apr 16 , 2020.
this PR bumps rockdsb to 6.20.3, which is build on May 5, 2021, and includes many new bug-fix
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5208
## How was this patch tested?
no need to add additional tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-838170638
> in my local test , integration(ozone) test is passed, but it fail here. is it a flaky case?
`TestOzoneManagerRocksDBLogging` has not been flaky recently, plus it looks related. I guess the problem could be that output may be changed in the new version.
(BTW, please trigger CI with empty commit instead of closing+reopening the PR. This makes it easier to see previous CI results.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-840981882
> Now with the new version there is a 15-sec delay. @avijayanhwx Would it make sense to check for `rocksdb.RocksDB` instead? I think it would appear in all lines coming from RocksDB:
@adoroszlai , in this test case , it seems that server rocksdb benchmarks are carried out and then the corresponding benchmark stats are dumped. so I think maybe in this version of rocksdb , more benchmarks are involved , and thus it takes longer time to complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-840936474
> Retriggered the build to be sure that the (possible) intermittency is disappeared. If it passes, I am +1 to merge it.
thanks @elek for the retrigger。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 closed pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 closed pull request #2235:
URL: https://github.com/apache/ozone/pull/2235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-839436114
@adoroszlai i make the wait time longer ,and CI is passed. it seems we should wait longer for the log if we use the rocksdb of this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-838362038
> `TestOzoneManagerRocksDBLogging` has not been flaky recently, plus it looks related. I guess the problem could be that output may be changed in the new version.
ok, i will fix this
> (BTW, please trigger CI with empty commit instead of closing+reopening the PR. This makes it easier to see previous CI results.)
thanks, will take care of this in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-837705392
@elek please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 edited a comment on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 edited a comment on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-840936474
> Retriggered the build to be sure that the (possible) intermittency is disappeared. If it passes, I am +1 to merge it.
thanks @elek for the retrigger。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-840687783
> i make the wait time longer ,and CI is passed. it seems we should wait longer for the log if we use the rocksdb of this version.
Thanks for trying that.
The test expects the output `db_impl.cc`, which first appears when `DUMPING STATS`:
```
... [Thread-302] INFO rocksdb.RocksDB (DBStoreBuilder.java:log(304)) - [/db_impl/db_impl.cc:932] ------- DUMPING STATS -------
```
Now with the new version there is a 15-sec delay. @avijayanhwx Would it make sense to check for `rocksdb.RocksDB` instead? I think it would appear in all lines coming from RocksDB:
https://github.com/apache/ozone/blob/6b24c188df038f1ab404acace20a4060fe2114fd/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java#L64-L65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-838152699
@elek hi, in my local test , integration(ozone) test is passed, but it fail here. is it a flaky case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] avijayanhwx commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-840753297
> > i make the wait time longer ,and CI is passed. it seems we should wait longer for the log if we use the rocksdb of this version.
>
> Thanks for trying that.
>
> The test expects the output `db_impl.cc`, which first appears when `DUMPING STATS`:
>
> ```
> ... [Thread-302] INFO rocksdb.RocksDB (DBStoreBuilder.java:log(304)) - [/db_impl/db_impl.cc:932] ------- DUMPING STATS -------
> ```
>
> Now with the new version there is a 15-sec delay. @avijayanhwx Would it make sense to check for `rocksdb.RocksDB` instead? I think it would appear in all lines coming from RocksDB:
>
> https://github.com/apache/ozone/blob/6b24c188df038f1ab404acace20a4060fe2114fd/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java#L64-L65
Yes, I am ok with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-841041584
Thanks @JacksonYao287 for the patch, @elek for the review. We can address the delay separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 edited a comment on pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
JacksonYao287 edited a comment on pull request #2235:
URL: https://github.com/apache/ozone/pull/2235#issuecomment-840981882
> Now with the new version there is a 15-sec delay. @avijayanhwx Would it make sense to check for `rocksdb.RocksDB` instead? I think it would appear in all lines coming from RocksDB:
@adoroszlai , in this test case , it seems that several rocksdb benchmarks are carried out and then the corresponding benchmark stats are dumped. so I think maybe in this version of rocksdb , more benchmarks are involved , and thus it takes longer time to complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2235: HDDS-5208. bump rocksdb version to 6.20.3
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2235:
URL: https://github.com/apache/ozone/pull/2235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org