You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alastair Montgomery <am...@williamhill.co.uk> on 2017/08/26 13:14:33 UTC
Review Request 61927: MESOS-7912 In strict mode code,
functions can only be declared at top level
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61927/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-7912
https://issues.apache.org/jira/browse/MESOS-7912
Repository: mesos
Description
-------
Fix for https://issues.apache.org/jira/browse/MESOS-7912
Diffs
-----
src/webui/master/static/js/controllers.js 27456144c
Diff: https://reviews.apache.org/r/61927/diff/1/
Testing
-------
Tested in Chrome Windows Version Version 37.0.2062.102 m and Mesos UI is now displaying correctly where before it was throwing the strict error.
Thanks,
Alastair Montgomery
Re: Review Request 61927: MESOS-7912 In strict mode code,
functions can only be declared at top level
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61927/#review183909
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Aug. 26, 2017, 9:14 p.m., Alastair Montgomery wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61927/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2017, 9:14 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-7912
> https://issues.apache.org/jira/browse/MESOS-7912
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix for https://issues.apache.org/jira/browse/MESOS-7912
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 27456144c
>
>
> Diff: https://reviews.apache.org/r/61927/diff/1/
>
>
> Testing
> -------
>
> Tested in Chrome Windows Version Version 37.0.2062.102 m and Mesos UI is now displaying correctly where before it was throwing the strict error.
>
>
> Thanks,
>
> Alastair Montgomery
>
>
Re: Review Request 61927: MESOS-7912 In strict mode code,
functions can only be declared at top level
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61927/#review183896
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Aug. 26, 2017, 1:14 p.m., Alastair Montgomery wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61927/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2017, 1:14 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-7912
> https://issues.apache.org/jira/browse/MESOS-7912
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix for https://issues.apache.org/jira/browse/MESOS-7912
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 27456144c
>
>
> Diff: https://reviews.apache.org/r/61927/diff/1/
>
>
> Testing
> -------
>
> Tested in Chrome Windows Version Version 37.0.2062.102 m and Mesos UI is now displaying correctly where before it was throwing the strict error.
>
>
> Thanks,
>
> Alastair Montgomery
>
>
Re: Review Request 61927: MESOS-7912 In strict mode code,
functions can only be declared at top level
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61927/#review184015
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 26, 2017, 1:14 p.m., Alastair Montgomery wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61927/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2017, 1:14 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-7912
> https://issues.apache.org/jira/browse/MESOS-7912
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix for https://issues.apache.org/jira/browse/MESOS-7912
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 27456144c
>
>
> Diff: https://reviews.apache.org/r/61927/diff/1/
>
>
> Testing
> -------
>
> Tested in Chrome Windows Version Version 37.0.2062.102 m and Mesos UI is now displaying correctly where before it was throwing the strict error.
>
>
> Thanks,
>
> Alastair Montgomery
>
>