[GitHub] [parquet-mr] richardkerr commented on a diff in pull request #1048: PARQUET-2081: Fix support for files without ColumnIndexes

["richardkerr (via GitHub)" <gi...@apache.org>]

richardkerr commented on code in PR #1048:
URL: https://github.com/apache/parquet-mr/pull/1048#discussion_r1162736648


##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1127,7 +1127,7 @@ public void appendColumnChunk(ColumnDescriptor descriptor, SeekableInputStream f
     long length = chunk.getTotalSize();
     long newChunkStart = out.getPos();
 
-    if (newChunkStart != start) {
+    if (offsetIndex != null && newChunkStart != start) {

Review Comment:
   Found a file without ColumnIndexes that was added for another test case - if you have any advice how it could be generated instead I'd be happy to hear but it looks prohibitive to do so with the current implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org