You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Aljoscha Krettek <al...@apache.org> on 2018/03/15 00:40:00 UTC
[DISCUSS] Not marking Jira issues as resolved in 1.5.0 as resolved in
1.6.0
Hi,
We currently have some issues that are marked as resolved for both 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch and the master branch, which will eventually become the branch for 1.6.0.
I think this can lead to confusion because the release notes are created based on that data. Say, we fix a bug "foo" after we created the release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0 release notes with around 50 issues that were never bugs in 1.6.0 because they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0 (because we now had to fix it), but it wasn't.
I would propose to remove fixVersion 1.6.0 from all issues that have 1.5.0 as fixVersion. What do you think?
On a side note: a bug that is fixed in 1.5.1 should be marked as fixed for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
Best,
Aljoscha
[1] https://issues.apache.org/jira/issues/?jql=project%20%3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%20unresolved
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Aljoscha Krettek <al...@apache.org>.
Nice, it seems we're in agreement. I'll batch-edit the existing issues to remove the 1.6.0 fixVersion.
Aljoscha
> On 15. Mar 2018, at 08:34, Thomas Weise <th...@apache.org> wrote:
>
> +1
>
> Since it is guaranteed that all pre 1.5.0 release patches also make it to
> master, it would be confusing to mark them resolved for 1.6.x.
>
>
> On Thu, Mar 15, 2018 at 8:25 AM, Stephan Ewen <se...@apache.org> wrote:
>
>> +1
>>
>> Important: Please still write in the notes (when closing the issue) the
>> commit hashes for both 1.5 (release-1.5) and 1.6 (master).
>> Otherwise it makes hind-sight digging into the fixed more complicated.
>>
>>
>>
>> On Thu, Mar 15, 2018 at 3:28 PM, Felix Cheung <fe...@hotmail.com>
>> wrote:
>>
>>> +1
>>>
>>> ________________________________
>>> From: Till Rohrmann <tr...@apache.org>
>>> Sent: Thursday, March 15, 2018 5:45:14 AM
>>> To: dev@flink.apache.org
>>> Subject: Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
>>> resolved in 1.6.0
>>>
>>> +1 for marking bugs as fixed 1.5.0 only
>>>
>>> On Thu, Mar 15, 2018 at 11:09 AM, Ted Yu <yu...@gmail.com> wrote:
>>>
>>>> +1 on marking bugs as fixed for 1.5.0 only.
>>>> -------- Original message --------From: Piotr Nowojski <
>>>> piotr@data-artisans.com> Date: 3/15/18 12:48 AM (GMT-08:00) To:
>>>> dev@flink.apache.org Subject: Re: [DISCUSS] Not marking Jira issues as
>>>> resolved in 1.5.0 as resolved in 1.6.0
>>>> Same as Chesnay
>>>>
>>>> +1 for marking bugs as fixed 1.5.0 only
>>>>
>>>>> On 15 Mar 2018, at 07:57, Chesnay Schepler <ch...@apache.org>
>> wrote:
>>>>>
>>>>> +1 to mark bugs as fixed in 1.5.0 only.
>>>>>
>>>>> On 15.03.2018 01:40, Aljoscha Krettek wrote:
>>>>>> Hi,
>>>>>>
>>>>>> We currently have some issues that are marked as resolved for both
>>>> 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch
>>> and
>>>> the master branch, which will eventually become the branch for 1.6.0.
>>>>>>
>>>>>> I think this can lead to confusion because the release notes are
>>>> created based on that data. Say, we fix a bug "foo" after we created
>> the
>>>> release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the
>>>> release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0
>>>> release notes with around 50 issues that were never bugs in 1.6.0
>> because
>>>> they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the
>>>> 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0
>>>> (because we now had to fix it), but it wasn't.
>>>>>>
>>>>>> I would propose to remove fixVersion 1.6.0 from all issues that have
>>>> 1.5.0 as fixVersion. What do you think?
>>>>>>
>>>>>> On a side note: a bug that is fixed in 1.5.1 should be marked as
>> fixed
>>>> for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
>>>>>>
>>>>>> Best,
>>>>>> Aljoscha
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/issues/?jql=project%20%
>>>> 3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%
>>>> 20unresolved
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Thomas Weise <th...@apache.org>.
+1
Since it is guaranteed that all pre 1.5.0 release patches also make it to
master, it would be confusing to mark them resolved for 1.6.x.
On Thu, Mar 15, 2018 at 8:25 AM, Stephan Ewen <se...@apache.org> wrote:
> +1
>
> Important: Please still write in the notes (when closing the issue) the
> commit hashes for both 1.5 (release-1.5) and 1.6 (master).
> Otherwise it makes hind-sight digging into the fixed more complicated.
>
>
>
> On Thu, Mar 15, 2018 at 3:28 PM, Felix Cheung <fe...@hotmail.com>
> wrote:
>
> > +1
> >
> > ________________________________
> > From: Till Rohrmann <tr...@apache.org>
> > Sent: Thursday, March 15, 2018 5:45:14 AM
> > To: dev@flink.apache.org
> > Subject: Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
> > resolved in 1.6.0
> >
> > +1 for marking bugs as fixed 1.5.0 only
> >
> > On Thu, Mar 15, 2018 at 11:09 AM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > +1 on marking bugs as fixed for 1.5.0 only.
> > > -------- Original message --------From: Piotr Nowojski <
> > > piotr@data-artisans.com> Date: 3/15/18 12:48 AM (GMT-08:00) To:
> > > dev@flink.apache.org Subject: Re: [DISCUSS] Not marking Jira issues as
> > > resolved in 1.5.0 as resolved in 1.6.0
> > > Same as Chesnay
> > >
> > > +1 for marking bugs as fixed 1.5.0 only
> > >
> > > > On 15 Mar 2018, at 07:57, Chesnay Schepler <ch...@apache.org>
> wrote:
> > > >
> > > > +1 to mark bugs as fixed in 1.5.0 only.
> > > >
> > > > On 15.03.2018 01:40, Aljoscha Krettek wrote:
> > > >> Hi,
> > > >>
> > > >> We currently have some issues that are marked as resolved for both
> > > 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch
> > and
> > > the master branch, which will eventually become the branch for 1.6.0.
> > > >>
> > > >> I think this can lead to confusion because the release notes are
> > > created based on that data. Say, we fix a bug "foo" after we created
> the
> > > release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the
> > > release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0
> > > release notes with around 50 issues that were never bugs in 1.6.0
> because
> > > they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the
> > > 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0
> > > (because we now had to fix it), but it wasn't.
> > > >>
> > > >> I would propose to remove fixVersion 1.6.0 from all issues that have
> > > 1.5.0 as fixVersion. What do you think?
> > > >>
> > > >> On a side note: a bug that is fixed in 1.5.1 should be marked as
> fixed
> > > for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
> > > >>
> > > >> Best,
> > > >> Aljoscha
> > > >>
> > > >> [1] https://issues.apache.org/jira/issues/?jql=project%20%
> > > 3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%
> > > 20unresolved
> > > >
> > > >
> > >
> > >
> >
>
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Stephan Ewen <se...@apache.org>.
+1
Important: Please still write in the notes (when closing the issue) the
commit hashes for both 1.5 (release-1.5) and 1.6 (master).
Otherwise it makes hind-sight digging into the fixed more complicated.
On Thu, Mar 15, 2018 at 3:28 PM, Felix Cheung <fe...@hotmail.com>
wrote:
> +1
>
> ________________________________
> From: Till Rohrmann <tr...@apache.org>
> Sent: Thursday, March 15, 2018 5:45:14 AM
> To: dev@flink.apache.org
> Subject: Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
> resolved in 1.6.0
>
> +1 for marking bugs as fixed 1.5.0 only
>
> On Thu, Mar 15, 2018 at 11:09 AM, Ted Yu <yu...@gmail.com> wrote:
>
> > +1 on marking bugs as fixed for 1.5.0 only.
> > -------- Original message --------From: Piotr Nowojski <
> > piotr@data-artisans.com> Date: 3/15/18 12:48 AM (GMT-08:00) To:
> > dev@flink.apache.org Subject: Re: [DISCUSS] Not marking Jira issues as
> > resolved in 1.5.0 as resolved in 1.6.0
> > Same as Chesnay
> >
> > +1 for marking bugs as fixed 1.5.0 only
> >
> > > On 15 Mar 2018, at 07:57, Chesnay Schepler <ch...@apache.org> wrote:
> > >
> > > +1 to mark bugs as fixed in 1.5.0 only.
> > >
> > > On 15.03.2018 01:40, Aljoscha Krettek wrote:
> > >> Hi,
> > >>
> > >> We currently have some issues that are marked as resolved for both
> > 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch
> and
> > the master branch, which will eventually become the branch for 1.6.0.
> > >>
> > >> I think this can lead to confusion because the release notes are
> > created based on that data. Say, we fix a bug "foo" after we created the
> > release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the
> > release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0
> > release notes with around 50 issues that were never bugs in 1.6.0 because
> > they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the
> > 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0
> > (because we now had to fix it), but it wasn't.
> > >>
> > >> I would propose to remove fixVersion 1.6.0 from all issues that have
> > 1.5.0 as fixVersion. What do you think?
> > >>
> > >> On a side note: a bug that is fixed in 1.5.1 should be marked as fixed
> > for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
> > >>
> > >> Best,
> > >> Aljoscha
> > >>
> > >> [1] https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%
> > 20unresolved
> > >
> > >
> >
> >
>
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Felix Cheung <fe...@hotmail.com>.
+1
________________________________
From: Till Rohrmann <tr...@apache.org>
Sent: Thursday, March 15, 2018 5:45:14 AM
To: dev@flink.apache.org
Subject: Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as resolved in 1.6.0
+1 for marking bugs as fixed 1.5.0 only
On Thu, Mar 15, 2018 at 11:09 AM, Ted Yu <yu...@gmail.com> wrote:
> +1 on marking bugs as fixed for 1.5.0 only.
> -------- Original message --------From: Piotr Nowojski <
> piotr@data-artisans.com> Date: 3/15/18 12:48 AM (GMT-08:00) To:
> dev@flink.apache.org Subject: Re: [DISCUSS] Not marking Jira issues as
> resolved in 1.5.0 as resolved in 1.6.0
> Same as Chesnay
>
> +1 for marking bugs as fixed 1.5.0 only
>
> > On 15 Mar 2018, at 07:57, Chesnay Schepler <ch...@apache.org> wrote:
> >
> > +1 to mark bugs as fixed in 1.5.0 only.
> >
> > On 15.03.2018 01:40, Aljoscha Krettek wrote:
> >> Hi,
> >>
> >> We currently have some issues that are marked as resolved for both
> 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch and
> the master branch, which will eventually become the branch for 1.6.0.
> >>
> >> I think this can lead to confusion because the release notes are
> created based on that data. Say, we fix a bug "foo" after we created the
> release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the
> release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0
> release notes with around 50 issues that were never bugs in 1.6.0 because
> they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the
> 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0
> (because we now had to fix it), but it wasn't.
> >>
> >> I would propose to remove fixVersion 1.6.0 from all issues that have
> 1.5.0 as fixVersion. What do you think?
> >>
> >> On a side note: a bug that is fixed in 1.5.1 should be marked as fixed
> for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
> >>
> >> Best,
> >> Aljoscha
> >>
> >> [1] https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%
> 20unresolved
> >
> >
>
>
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Till Rohrmann <tr...@apache.org>.
+1 for marking bugs as fixed 1.5.0 only
On Thu, Mar 15, 2018 at 11:09 AM, Ted Yu <yu...@gmail.com> wrote:
> +1 on marking bugs as fixed for 1.5.0 only.
> -------- Original message --------From: Piotr Nowojski <
> piotr@data-artisans.com> Date: 3/15/18 12:48 AM (GMT-08:00) To:
> dev@flink.apache.org Subject: Re: [DISCUSS] Not marking Jira issues as
> resolved in 1.5.0 as resolved in 1.6.0
> Same as Chesnay
>
> +1 for marking bugs as fixed 1.5.0 only
>
> > On 15 Mar 2018, at 07:57, Chesnay Schepler <ch...@apache.org> wrote:
> >
> > +1 to mark bugs as fixed in 1.5.0 only.
> >
> > On 15.03.2018 01:40, Aljoscha Krettek wrote:
> >> Hi,
> >>
> >> We currently have some issues that are marked as resolved for both
> 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch and
> the master branch, which will eventually become the branch for 1.6.0.
> >>
> >> I think this can lead to confusion because the release notes are
> created based on that data. Say, we fix a bug "foo" after we created the
> release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the
> release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0
> release notes with around 50 issues that were never bugs in 1.6.0 because
> they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the
> 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0
> (because we now had to fix it), but it wasn't.
> >>
> >> I would propose to remove fixVersion 1.6.0 from all issues that have
> 1.5.0 as fixVersion. What do you think?
> >>
> >> On a side note: a bug that is fixed in 1.5.1 should be marked as fixed
> for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
> >>
> >> Best,
> >> Aljoscha
> >>
> >> [1] https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%
> 20unresolved
> >
> >
>
>
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Ted Yu <yu...@gmail.com>.
+1 on marking bugs as fixed for 1.5.0 only.
-------- Original message --------From: Piotr Nowojski <pi...@data-artisans.com> Date: 3/15/18 12:48 AM (GMT-08:00) To: dev@flink.apache.org Subject: Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as resolved in 1.6.0
Same as Chesnay
+1 for marking bugs as fixed 1.5.0 only
> On 15 Mar 2018, at 07:57, Chesnay Schepler <ch...@apache.org> wrote:
>
> +1 to mark bugs as fixed in 1.5.0 only.
>
> On 15.03.2018 01:40, Aljoscha Krettek wrote:
>> Hi,
>>
>> We currently have some issues that are marked as resolved for both 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch and the master branch, which will eventually become the branch for 1.6.0.
>>
>> I think this can lead to confusion because the release notes are created based on that data. Say, we fix a bug "foo" after we created the release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0 release notes with around 50 issues that were never bugs in 1.6.0 because they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0 (because we now had to fix it), but it wasn't.
>>
>> I would propose to remove fixVersion 1.6.0 from all issues that have 1.5.0 as fixVersion. What do you think?
>>
>> On a side note: a bug that is fixed in 1.5.1 should be marked as fixed for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
>>
>> Best,
>> Aljoscha
>>
>> [1] https://issues.apache.org/jira/issues/?jql=project%20%3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%20unresolved
>
>
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Piotr Nowojski <pi...@data-artisans.com>.
Same as Chesnay
+1 for marking bugs as fixed 1.5.0 only
> On 15 Mar 2018, at 07:57, Chesnay Schepler <ch...@apache.org> wrote:
>
> +1 to mark bugs as fixed in 1.5.0 only.
>
> On 15.03.2018 01:40, Aljoscha Krettek wrote:
>> Hi,
>>
>> We currently have some issues that are marked as resolved for both 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch and the master branch, which will eventually become the branch for 1.6.0.
>>
>> I think this can lead to confusion because the release notes are created based on that data. Say, we fix a bug "foo" after we created the release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0 release notes with around 50 issues that were never bugs in 1.6.0 because they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0 (because we now had to fix it), but it wasn't.
>>
>> I would propose to remove fixVersion 1.6.0 from all issues that have 1.5.0 as fixVersion. What do you think?
>>
>> On a side note: a bug that is fixed in 1.5.1 should be marked as fixed for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
>>
>> Best,
>> Aljoscha
>>
>> [1] https://issues.apache.org/jira/issues/?jql=project%20%3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%20unresolved
>
>
Re: [DISCUSS] Not marking Jira issues as resolved in 1.5.0 as
resolved in 1.6.0
Posted by Chesnay Schepler <ch...@apache.org>.
+1 to mark bugs as fixed in 1.5.0 only.
On 15.03.2018 01:40, Aljoscha Krettek wrote:
> Hi,
>
> We currently have some issues that are marked as resolved for both 1.5.0 and 1.6.0 [1]. The reason is that we have the release-1.5 branch and the master branch, which will eventually become the branch for 1.6.0.
>
> I think this can lead to confusion because the release notes are created based on that data. Say, we fix a bug "foo" after we created the release-1.5 branch. Now we will have "[FLINK-xxxx] Fixed foo" in the release notes for 1.5.0 and 1.6.0. We basically start our Flink 1.6.0 release notes with around 50 issues that were never bugs in 1.6.0 because they were fixed in 1.5.0. Plus, having "[FLINK-xxxx] Fixed foo" in the 1.6.0 release notes indicates that "foo" was actually a bug in 1.5.0 (because we now had to fix it), but it wasn't.
>
> I would propose to remove fixVersion 1.6.0 from all issues that have 1.5.0 as fixVersion. What do you think?
>
> On a side note: a bug that is fixed in 1.5.1 should be marked as fixed for 1.6.0 separately, because 1.6.0 is not a direct successor to 1.5.1.
>
> Best,
> Aljoscha
>
> [1] https://issues.apache.org/jira/issues/?jql=project%20%3D%20FLINK%20and%20fixVersion%20%3D%201.6.0%20and%20resolution%20!%3D%20unresolved