You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/30 13:26:06 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
danny0405 opened a new pull request, #5716:
URL: https://github.com/apache/hudi/pull/5716
The timeline refresh invokes the fs view #sync, which has two actions now:
1. reload the timeline of the fs view, so that the nest fs view request is based on this timeline metadata
2. if this is a local fs view, clear all the local states or if this is a remote fs view, send request to sync the remote fs view
But, let's see the construction, the meta client is instantiated freshly so the timeline is already the latest,
the table is also constructed freshly, so the fs view has no local states, that means, the #sync is unnecessary totally.
Removes the timeline refresh has a benifit: if avoids unncecessary #refresh of the remote fs view, if all the clients send request to
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931721050
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -364,8 +364,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Boolean> REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT = ConfigProperty
.key("hoodie.refresh.timeline.server.based.on.latest.commit")
- .defaultValue(false)
- .withDocumentation("Refresh timeline in timeline server based on latest commit apart from timeline hash difference. By default (false), ");
+ .defaultValue(true)
Review Comment:
> hy can't we keep it as false
It is actually hard code to be true before this patch and this config option is fixed to be effective only after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 closed pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
URL: https://github.com/apache/hudi/pull/5716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143273764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024)
* 664853e71b8433d4e482948d84a590b50e12527f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143099333
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* e7a2ec964dca5600dbc6f514c1b82b3d630a56d9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015)
* 7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1141200679
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 624e5c0cfefd7b41da92228b2f9be70aa8ee95af UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1144103485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
}, {
"hash" : "4912e107cbdce0df72d855d656107777eafcb85a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035",
"triggerID" : "4912e107cbdce0df72d855d656107777eafcb85a",
"triggerType" : "PUSH"
}, {
"hash" : "4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9038",
"triggerID" : "4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 4912e107cbdce0df72d855d656107777eafcb85a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035)
* 4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9038)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143901406
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
}, {
"hash" : "4912e107cbdce0df72d855d656107777eafcb85a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035",
"triggerID" : "4912e107cbdce0df72d855d656107777eafcb85a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 4912e107cbdce0df72d855d656107777eafcb85a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143125433
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* e7a2ec964dca5600dbc6f514c1b82b3d630a56d9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015)
* 7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931721050
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -364,8 +364,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Boolean> REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT = ConfigProperty
.key("hoodie.refresh.timeline.server.based.on.latest.commit")
- .defaultValue(false)
- .withDocumentation("Refresh timeline in timeline server based on latest commit apart from timeline hash difference. By default (false), ");
+ .defaultValue(true)
Review Comment:
> hy can't we keep it as false
It is actually hard code to be true before this patch and this config option is fixed to be effective only in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931721763
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -567,6 +564,16 @@ private synchronized void close(Pair<String, String> partitionFileSlicePair) {
closeReader(readers);
}
+ /**
+ * Close and clear all the partitions readers.
+ */
+ private void closePartitionReaders() {
Review Comment:
No, it is related, because in this patch, we refresh the metadata table when the fs view is refreshed, and there are some states in the readers we need to clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1144096116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
}, {
"hash" : "4912e107cbdce0df72d855d656107777eafcb85a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035",
"triggerID" : "4912e107cbdce0df72d855d656107777eafcb85a",
"triggerType" : "PUSH"
}, {
"hash" : "4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 4912e107cbdce0df72d855d656107777eafcb85a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035)
* 4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143599248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 664853e71b8433d4e482948d84a590b50e12527f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931721050
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -364,8 +364,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Boolean> REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT = ConfigProperty
.key("hoodie.refresh.timeline.server.based.on.latest.commit")
- .defaultValue(false)
- .withDocumentation("Refresh timeline in timeline server based on latest commit apart from timeline hash difference. By default (false), ");
+ .defaultValue(true)
Review Comment:
> hy can't we keep it as false
It is actually hard code to be true before this patch and this config option is fixed to be effective only after this PR.
Take a look at
[TimelineService.java](https://github.com/apache/hudi/pull/5716/files#diff-f6c3ec8d427d1c5586445abd044ac8c94131bc1a8d40482b85a2815ca32b03f7)
And it's weird that this config options is totally ignored and hard code to be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931721763
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -567,6 +564,16 @@ private synchronized void close(Pair<String, String> partitionFileSlicePair) {
closeReader(readers);
}
+ /**
+ * Close and clear all the partitions readers.
+ */
+ private void closePartitionReaders() {
Review Comment:
No, it is related, because in this patch, we refresh the metadata table when the fs view is refreshed, and there are some states in the readers we need to clear about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r929873650
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -567,6 +564,16 @@ private synchronized void close(Pair<String, String> partitionFileSlicePair) {
closeReader(readers);
}
+ /**
+ * Close and clear all the partitions readers.
+ */
+ private void closePartitionReaders() {
Review Comment:
this kind of refactoring also seems strictly not needed here in the same PR?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/RocksDbBasedFileSystemView.java:
##########
@@ -199,6 +199,7 @@ protected void resetViewState() {
LOG.info("Deleting all rocksdb data associated with table filesystem view");
rocksDB.close();
rocksDB = new RocksDBDAO(metaClient.getBasePath(), config.getRocksdbBasePath());
+ schemaHelper.getAllColumnFamilies().forEach(rocksDB::addColumnFamily);
Review Comment:
please avoid unrelated changes in the same PR
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -364,8 +364,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Boolean> REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT = ConfigProperty
.key("hoodie.refresh.timeline.server.based.on.latest.commit")
- .defaultValue(false)
- .withDocumentation("Refresh timeline in timeline server based on latest commit apart from timeline hash difference. By default (false), ");
+ .defaultValue(true)
Review Comment:
I don't know if we are ready for this flip yet. there are probably some open JIRAs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1141993135
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* e7a2ec964dca5600dbc6f514c1b82b3d630a56d9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143621949
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 664853e71b8433d4e482948d84a590b50e12527f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031)
* 12dda8d37823fd0f00a36aa45ca6b81ff90b71b1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143216525
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1144200057
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
}, {
"hash" : "4912e107cbdce0df72d855d656107777eafcb85a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035",
"triggerID" : "4912e107cbdce0df72d855d656107777eafcb85a",
"triggerType" : "PUSH"
}, {
"hash" : "4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9038",
"triggerID" : "4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 4cdec00e44a2fbbe86a4d8e1557b3e63a25ff08e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9038)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1141941739
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 624e5c0cfefd7b41da92228b2f9be70aa8ee95af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009)
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1141204911
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 624e5c0cfefd7b41da92228b2f9be70aa8ee95af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143482175
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 664853e71b8433d4e482948d84a590b50e12527f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931670720
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -364,8 +364,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Boolean> REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT = ConfigProperty
.key("hoodie.refresh.timeline.server.based.on.latest.commit")
- .defaultValue(false)
- .withDocumentation("Refresh timeline in timeline server based on latest commit apart from timeline hash difference. By default (false), ");
+ .defaultValue(true)
Review Comment:
This removed in https://github.com/apache/hudi/pull/6179
but @danny0405 why can't we keep it as false? removing it completely is a breaking change. and normally we would at least deprecate it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143813238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
}, {
"hash" : "4912e107cbdce0df72d855d656107777eafcb85a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035",
"triggerID" : "4912e107cbdce0df72d855d656107777eafcb85a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 12dda8d37823fd0f00a36aa45ca6b81ff90b71b1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033)
* 4912e107cbdce0df72d855d656107777eafcb85a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9035)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143220110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143478664
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143269131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024)
* 664853e71b8433d4e482948d84a590b50e12527f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931721050
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -364,8 +364,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Boolean> REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT = ConfigProperty
.key("hoodie.refresh.timeline.server.based.on.latest.commit")
- .defaultValue(false)
- .withDocumentation("Refresh timeline in timeline server based on latest commit apart from timeline hash difference. By default (false), ");
+ .defaultValue(true)
Review Comment:
> hy can't we keep it as false
It is actually hard code to be true before this patch and this config option is fixed to be effective only after this PR.
Take a look at `TimelineService#refreshTimelineBasedOnLatestCommit`, it's weird that the member is hard code to be true and there is no way to config it before this patch, config option `REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT` is totally ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5716:
URL: https://github.com/apache/hudi/pull/5716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143409098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 664853e71b8433d4e482948d84a590b50e12527f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931725039
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/RocksDbBasedFileSystemView.java:
##########
@@ -199,6 +199,7 @@ protected void resetViewState() {
LOG.info("Deleting all rocksdb data associated with table filesystem view");
rocksDB.close();
rocksDB = new RocksDBDAO(metaClient.getBasePath(), config.getRocksdbBasePath());
+ schemaHelper.getAllColumnFamilies().forEach(rocksDB::addColumnFamily);
Review Comment:
It is a necessary fix actually, to fix the refresh of the fs view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143216369
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143603917
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 664853e71b8433d4e482948d84a590b50e12527f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031)
* 12dda8d37823fd0f00a36aa45ca6b81ff90b71b1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143669780
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
}, {
"hash" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033",
"triggerID" : "12dda8d37823fd0f00a36aa45ca6b81ff90b71b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 12dda8d37823fd0f00a36aa45ca6b81ff90b71b1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9033)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143485652
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "1143216369",
"triggerType" : "MANUAL"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027",
"triggerID" : "664853e71b8433d4e482948d84a590b50e12527f",
"triggerType" : "PUSH"
}, {
"hash" : "664853e71b8433d4e482948d84a590b50e12527f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031",
"triggerID" : "1143478664",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 664853e71b8433d4e482948d84a590b50e12527f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9027) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9031)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1141942362
@prashantwason @nsivabalan Can you guys take a look at this PR if you have time, thanks in advance ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1141949155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 624e5c0cfefd7b41da92228b2f9be70aa8ee95af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009)
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* e7a2ec964dca5600dbc6f514c1b82b3d630a56d9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1141945459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 624e5c0cfefd7b41da92228b2f9be70aa8ee95af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009)
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* e7a2ec964dca5600dbc6f514c1b82b3d630a56d9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1143202499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9009",
"triggerID" : "624e5c0cfefd7b41da92228b2f9be70aa8ee95af",
"triggerType" : "PUSH"
}, {
"hash" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db8e1c36c61092e8e404a6533b48a5357a99458c",
"triggerType" : "PUSH"
}, {
"hash" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9015",
"triggerID" : "e7a2ec964dca5600dbc6f514c1b82b3d630a56d9",
"triggerType" : "PUSH"
}, {
"hash" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024",
"triggerID" : "7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db8e1c36c61092e8e404a6533b48a5357a99458c UNKNOWN
* 7e8301c9ba6d0d5e7998c1e91e7facfbce2738a8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9024)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] weimingdiit commented on pull request #5716: [HUDI-4167] Remove the timeline refresh with initializing hoodie table
Posted by GitBox <gi...@apache.org>.
weimingdiit commented on PR #5716:
URL: https://github.com/apache/hudi/pull/5716#issuecomment-1343802172
【But, let's see the construction, the meta client is instantiated freshly so the timeline is already the latest,
the table is also constructed freshly】
Can you explain this in detail? I'm a little confused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org