You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/10 06:01:43 UTC
[GitHub] [incubator-doris] vagetablechicken opened a new pull request #4068: [Compaction] track RowsetReader's mem & add metric
vagetablechicken opened a new pull request #4068:
URL: https://github.com/apache/incubator-doris/pull/4068
Ref https://github.com/apache/incubator-doris/issues/3624#issuecomment-655933244
Only RowsetReaders in compaction are under the track.
Other RowsetReaders won't be effected, because the parent_tracker is nullptr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #4068: [Compaction] track RowsetReader's mem & add metric
Posted by GitBox <gi...@apache.org>.
vagetablechicken commented on a change in pull request #4068:
URL: https://github.com/apache/incubator-doris/pull/4068#discussion_r455495127
##########
File path: be/src/olap/compaction.h
##########
@@ -77,6 +77,8 @@ class Compaction {
int64_t _get_input_num_rows_from_seg_grps();
protected:
+ MemTracker _mem_tracker;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4068: [Compaction] track RowsetReader's mem & add metric
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4068:
URL: https://github.com/apache/incubator-doris/pull/4068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vagetablechicken commented on pull request #4068: [Compaction] track RowsetReader's mem & add metric
Posted by GitBox <gi...@apache.org>.
vagetablechicken commented on pull request #4068:
URL: https://github.com/apache/incubator-doris/pull/4068#issuecomment-661597974
> Hi @vagetablechicken , Plz add this new metrics to the document `be-metrics.md`, Thank you
Finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4068: [Compaction] track RowsetReader's mem & add metric
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4068:
URL: https://github.com/apache/incubator-doris/pull/4068#discussion_r455159487
##########
File path: be/src/olap/compaction.h
##########
@@ -77,6 +77,8 @@ class Compaction {
int64_t _get_input_num_rows_from_seg_grps();
protected:
+ MemTracker _mem_tracker;
Review comment:
Please add comment to these mem trackers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org