You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by "Scott Cantor (JIRA)" <ji...@apache.org> on 2017/09/04 18:49:01 UTC
[jira] [Commented] (SANTUARIO-471) Patch for C++11 compile failures
[ https://issues.apache.org/jira/browse/SANTUARIO-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152861#comment-16152861 ]
Scott Cantor commented on SANTUARIO-471:
----------------------------------------
BTW, I'd like to consider CMake-ifying this but it may be a little beyond me due to the OpenSSL 1.1 conditional tests. I don't know if you're using this library at all but if you are and are willing to take that on, let me know. Otherwise I'll probably try and take a stab at it.
> Patch for C++11 compile failures
> --------------------------------
>
> Key: SANTUARIO-471
> URL: https://issues.apache.org/jira/browse/SANTUARIO-471
> Project: Santuario
> Issue Type: Bug
> Components: C++
> Affects Versions: C++ 1.7.0, C++ 1.7.1, C++ 1.7.2, C++ 1.7.3
> Environment: C++11
> Reporter: Roger Leigh
> Assignee: Scott Cantor
> Labels: c++11
> Fix For: C++ 2.0.0
>
> Attachments: patch-xsec_enc_NSS_NSSCryptoSymmetricKey.hpp, patch-xsec_enc_OpenSSL_OpenSSLCryptoSymmetricKey.hpp, patch-xsec_enc_WinCAPI_WinCAPICryptoSymmetricKey.hpp, patch-xsec_enc_XSECCryptoSymmetricKey.hpp, patch-xsec_tools_checksig_InteropResolver.cpp
>
>
> The source code has a number of bugs in it which are silently compiled pre-C++11 but with C++11 implicit conversions are stricter and this results in compile failure. The attached patches fix them up.
> This is needed to compile with Xerces-C 3.2.0 when Xerces-C was built with a C++11 compiler, and char16_t usage was enabled.
> I've already done the Apache CLA stuff, by the way.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)