[GitHub] qpid pull request: Get qpid C++ building on OSX.

[astitcher <gi...@git.apache.org>]

Github user astitcher commented on the pull request:

    https://github.com/apache/qpid/pull/7#issuecomment-101935319
  
    This implementation doesn't follow the usual qpid portability strategy for *not* introducing inline conditional compilation.
    
    The way we do do this in qpid is to introduce a new file for the platform and compile that as an alternative implementation. the posix/Time.cpp file is more-or-les reimplemented so this needs to be a new file with the new implementation and not switched using long term unmaintainable #ifdefs.
    
    Also I think that you will have a fundamental problem with timekeeping if condvars can't use monotonic clocks - You will basically have to have a custom OSX implementation of timekeeping and condvars. As you can't have one use a monotonic clock without the other
    
    Also we don't need a commit to remove commented out stuff, when the it was the other commit in the pull request that introduced it, please just squash them together.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org