You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/24 19:16:00 UTC
[jira] [Commented] (SAMZA-1677) Make httpcore and httpclient
dependencies consistent
[ https://issues.apache.org/jira/browse/SAMZA-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489627#comment-16489627 ]
ASF GitHub Bot commented on SAMZA-1677:
---------------------------------------
GitHub user cameronlee314 opened a pull request:
https://github.com/apache/samza/pull/534
SAMZA-1677 : Make httpcore and httpclient dependencies consistent
Samza currently depends on httpclient 4.5.2 and httpcore 4.4.5. However, httpclient 4.5.2 also has a direct dependency on httpcore 4.4.4, which is not backwards compatible with httpcore 4.4.5 since some classes were removed (e.g. ThreadSafe/NotThreadSafe annotation classes).
Although this does not currently cause any direct build problems, there may be cases where this conflict introduces transitive dependency conflicts. In addition, this inconsistency can cause confusion in future development if those libraries need to be used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cameronlee314/samza httpcore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit a096acf87773e8914b553bba688b31d4fcb7a39d
Author: Cameron Lee <ca...@...>
Date: 2018-05-24T19:12:21Z
SAMZA-1677 : Make httpcore and httpclient dependencies consistent
----
> Make httpcore and httpclient dependencies consistent
> ----------------------------------------------------
>
> Key: SAMZA-1677
> URL: https://issues.apache.org/jira/browse/SAMZA-1677
> Project: Samza
> Issue Type: Improvement
> Reporter: Cameron Lee
> Assignee: Cameron Lee
> Priority: Minor
> Labels: dependencies
>
> Samza currently depends on httpclient 4.5.2 and httpcore 4.4.5. However, httpclient 4.5.2 also has a direct dependency on httpcore 4.4.4, which is not backwards compatible with httpcore 4.4.5 since some classes were removed (e.g. ThreadSafe/NotThreadSafe annotation classes).
> Although this does not currently cause any direct build problems, there may be cases where this conflict introduces transitive dependency conflicts. In addition, this inconsistency can cause confusion in future development if those libraries need to be used.
> Upgrading httpclient or downgrading (possibly just removing) httpcore should remove this conflict.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)