You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/12 20:09:38 UTC
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2860: Don't try to infer nullability in CSV reader
alamb commented on code in PR #2860:
URL: https://github.com/apache/arrow-rs/pull/2860#discussion_r993851607
##########
arrow/src/csv/reader.rs:
##########
@@ -214,12 +212,10 @@ fn infer_reader_schema_with_csv_options<R: Read>(
}
records_count += 1;
- for i in 0..header_length {
+ for (i, column_type) in column_types.iter_mut().enumerate().take(header_length) {
Review Comment:
```suggestion
// Note since we may be looking at a sample of the data, we make the safe assumption that
// they could be nullable
for (i, column_type) in column_types.iter_mut().enumerate().take(header_length) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org