You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2003/06/19 21:59:35 UTC

Re: svn commit: rev 6298 - in clients/rapidsvn/trunk: . src src/svncpp

xela@tigris.org writes:

> +    svn_error_t * error =
> +      svn_client_delete (&commit_info, 
> +                         const_cast<apr_array_header_t*> (targets.array (pool)), 

Eeww, that's ugly!  I've fixed svn_client_delete to take a const.

>                           force,
>                           *m_context,
>                           pool);
> @@ -184,9 +201,13 @@
>      Pool pool;
>      m_context->setLogMessage (message);
>  
> +    Targets targets (path.c_str ());
> +
>      svn_client_commit_info_t *commit_info = NULL;
>      svn_error_t * error =  
> -      svn_client_mkdir (&commit_info, path.c_str (),
> +      svn_client_mkdir (&commit_info, 
> +                        const_cast<apr_array_header_t*> 

Ditto svn_client_mkdir.

> +                        (targets.array (pool)),
>                          *m_context, pool);

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 6298 - in clients/rapidsvn/trunk: . src src/svncpp

Posted by cm...@collab.net.
Philip Martin <ph...@codematters.co.uk> writes:

> xela@tigris.org writes:
> 
> > +    svn_error_t * error =
> > +      svn_client_delete (&commit_info, 
> > +                         const_cast<apr_array_header_t*> (targets.array (pool)), 
> 
> Eeww, that's ugly!  I've fixed svn_client_delete to take a const.
> 
> >                           force,
> >                           *m_context,
> >                           pool);
> > @@ -184,9 +201,13 @@
> >      Pool pool;
> >      m_context->setLogMessage (message);
> >  
> > +    Targets targets (path.c_str ());
> > +
> >      svn_client_commit_info_t *commit_info = NULL;
> >      svn_error_t * error =  
> > -      svn_client_mkdir (&commit_info, path.c_str (),
> > +      svn_client_mkdir (&commit_info, 
> > +                        const_cast<apr_array_header_t*> 
> 
> Ditto svn_client_mkdir.
> 
> > +                        (targets.array (pool)),
> >                          *m_context, pool);

Thanks, Philip.  You just removed two of my personal TODO items!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org