[GitHub] [beam] jkff commented on a change in pull request #13585: [BEAM-10160] Change API to enable to append to Iceberg

[GitBox <gi...@apache.org>]

jkff commented on a change in pull request #13585:
URL: https://github.com/apache/beam/pull/13585#discussion_r546818013



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
##########
@@ -1741,9 +1740,8 @@ public void populateDisplayData(DisplayData.Builder builder) {
     }
 
     @Override
-    public PDone expand(PCollection<T> input) {
-      input.apply(inner);
-      return PDone.in(input.getPipeline());
+    public WriteFilesResult<?> expand(PCollection<T> input) {

Review comment:
       Agreed, this should use FileIO.write + AvroIO.sink - the current change is incompatible and will break anybody's transforms of the form:
   
   ```
   PDone expand(...) {
     ...
     return AvroIO.write()...;  // If return type changes to WFR, this stops compiling
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org