You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "David Bowen (JIRA)" <ji...@apache.org> on 2007/03/08 18:36:24 UTC
[jira] Created: (HADOOP-1091) NPE from Simon in JT stdout
NPE from Simon in JT stdout
------------------------------
Key: HADOOP-1091
URL: https://issues.apache.org/jira/browse/HADOOP-1091
Project: Hadoop
Issue Type: Bug
Reporter: David Bowen
Fix For: 0.12.1
Seen in JT std out:
Exception in thread "Timer-0" java.lang.NullPointerException
at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
at java.util.TimerThread.mainLoop(Timer.java:512)
at java.util.TimerThread.run(Timer.java:462)
There are (at least) two bugs:
(1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
cause this problem to happen (later) if value==null. It should treat a
null value as equivalent to an empty string.
(2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1091) NPE from Simon in JT stdout
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-1091:
--------------------------------
Status: Patch Available (was: Open)
My bad, the patch is fine. An editor I looked at the patch in removed the ^M end-o-line characters.
> NPE from Simon in JT stdout
> ------------------------------
>
> Key: HADOOP-1091
> URL: https://issues.apache.org/jira/browse/HADOOP-1091
> Project: Hadoop
> Issue Type: Bug
> Reporter: David Bowen
> Assigned To: David Bowen
> Fix For: 0.12.1
>
> Attachments: 1091.patch
>
>
> Seen in JT std out:
> Exception in thread "Timer-0" java.lang.NullPointerException
> at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
> There are (at least) two bugs:
> (1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
> cause this problem to happen (later) if value==null. It should treat a
> null value as equivalent to an empty string.
> (2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
> be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (HADOOP-1091) NPE from Simon in JT stdout
Posted by David Bowen <db...@yahoo-inc.com>.
>
> I've just fixed this. Thanks David! BTW, what's Simon?
>
Thanks Tom. Simon is a performance metrics monitoring system for
distributed applications. We have an interface for it that plugs in to
the service provider interface (SPI) in Hadoop metrics, allowing
close-to-real-time monitoring of Hadoop itself as well as for Hadoop
applications. Currently Simon is not open source, but we would like to
make it open source at some point.
- David
[jira] Updated: (HADOOP-1091) NPE from Simon in JT stdout
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-1091:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just fixed this. Thanks David! BTW, what's Simon?
> NPE from Simon in JT stdout
> ------------------------------
>
> Key: HADOOP-1091
> URL: https://issues.apache.org/jira/browse/HADOOP-1091
> Project: Hadoop
> Issue Type: Bug
> Reporter: David Bowen
> Assigned To: David Bowen
> Fix For: 0.12.1
>
> Attachments: 1091.patch
>
>
> Seen in JT std out:
> Exception in thread "Timer-0" java.lang.NullPointerException
> at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
> There are (at least) two bugs:
> (1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
> cause this problem to happen (later) if value==null. It should treat a
> null value as equivalent to an empty string.
> (2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
> be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1091) NPE from Simon in JT stdout
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479489 ]
Nigel Daley commented on HADOOP-1091:
-------------------------------------
This patch doesn't apply to trunk. I get:
patching file src/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
Hunk #1 FAILED at 64.
1 out of 1 hunk FAILED -- saving rejects to file src/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java.rej
patching file src/java/org/apache/hadoop/mapred/Counters.java
> NPE from Simon in JT stdout
> ------------------------------
>
> Key: HADOOP-1091
> URL: https://issues.apache.org/jira/browse/HADOOP-1091
> Project: Hadoop
> Issue Type: Bug
> Reporter: David Bowen
> Assigned To: David Bowen
> Fix For: 0.12.1
>
> Attachments: 1091.patch
>
>
> Seen in JT std out:
> Exception in thread "Timer-0" java.lang.NullPointerException
> at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
> There are (at least) two bugs:
> (1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
> cause this problem to happen (later) if value==null. It should treat a
> null value as equivalent to an empty string.
> (2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
> be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1091) NPE from Simon in JT stdout
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-1091:
--------------------------------
Status: Open (was: Patch Available)
Patch doesn't apply
> NPE from Simon in JT stdout
> ------------------------------
>
> Key: HADOOP-1091
> URL: https://issues.apache.org/jira/browse/HADOOP-1091
> Project: Hadoop
> Issue Type: Bug
> Reporter: David Bowen
> Assigned To: David Bowen
> Fix For: 0.12.1
>
> Attachments: 1091.patch
>
>
> Seen in JT std out:
> Exception in thread "Timer-0" java.lang.NullPointerException
> at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
> There are (at least) two bugs:
> (1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
> cause this problem to happen (later) if value==null. It should treat a
> null value as equivalent to an empty string.
> (2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
> be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1091) NPE from Simon in JT stdout
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bowen updated HADOOP-1091:
--------------------------------
Status: Patch Available (was: Open)
> NPE from Simon in JT stdout
> ------------------------------
>
> Key: HADOOP-1091
> URL: https://issues.apache.org/jira/browse/HADOOP-1091
> Project: Hadoop
> Issue Type: Bug
> Reporter: David Bowen
> Assigned To: David Bowen
> Fix For: 0.12.1
>
> Attachments: 1091.patch
>
>
> Seen in JT std out:
> Exception in thread "Timer-0" java.lang.NullPointerException
> at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
> There are (at least) two bugs:
> (1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
> cause this problem to happen (later) if value==null. It should treat a
> null value as equivalent to an empty string.
> (2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
> be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-1091) NPE from Simon in JT stdout
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bowen reassigned HADOOP-1091:
-----------------------------------
Assignee: David Bowen
> NPE from Simon in JT stdout
> ------------------------------
>
> Key: HADOOP-1091
> URL: https://issues.apache.org/jira/browse/HADOOP-1091
> Project: Hadoop
> Issue Type: Bug
> Reporter: David Bowen
> Assigned To: David Bowen
> Fix For: 0.12.1
>
>
> Seen in JT std out:
> Exception in thread "Timer-0" java.lang.NullPointerException
> at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
> There are (at least) two bugs:
> (1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
> cause this problem to happen (later) if value==null. It should treat a
> null value as equivalent to an empty string.
> (2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
> be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1091) NPE from Simon in JT stdout
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bowen updated HADOOP-1091:
--------------------------------
Attachment: 1091.patch
Two small, safe fixes.
> NPE from Simon in JT stdout
> ------------------------------
>
> Key: HADOOP-1091
> URL: https://issues.apache.org/jira/browse/HADOOP-1091
> Project: Hadoop
> Issue Type: Bug
> Reporter: David Bowen
> Assigned To: David Bowen
> Fix For: 0.12.1
>
> Attachments: 1091.patch
>
>
> Seen in JT std out:
> Exception in thread "Timer-0" java.lang.NullPointerException
> at com.yahoo.simon.hadoop.metrics.Client.computeBlurbSize(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.Client.sendBlurb(Unknown Source)
> at com.yahoo.simon.hadoop.metrics.SimonContext.emitRecord(Unknown Source)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.timerEvent(AbstractMetricsContext.java:295)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext.access$000(AbstractMetricsContext.java:48)
> at org.apache.hadoop.metrics.spi.AbstractMetricsContext$1.run(AbstractMetricsContext.java:242)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
> There are (at least) two bugs:
> (1) o.a.h.metrics.MetricsRecord.setTag(String name, String value) will
> cause this problem to happen (later) if value==null. It should treat a
> null value as equivalent to an empty string.
> (2) o.a.h.mapred.Counters.getGroupNames returns a collection which may
> be getting updated concurrently. It needs to make a copy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.