You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2011/06/18 22:52:39 UTC

DO NOT REPLY [Bug 51394] New: Code clean up (use apr_table_(set|add|merge)n variant when possible) #3

https://issues.apache.org/bugzilla/show_bug.cgi?id=51394

             Bug #: 51394
           Summary: Code clean up (use apr_table_(set|add|merge)n variant
                    when possible) #3
           Product: Apache httpd-2
           Version: 2.3-HEAD
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: All
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: christophe.jaillet@wanadoo.fr
    Classification: Unclassified


Created attachment 27175
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27175
Proposed patch

Hi,

here is another patch that apr_table_(set|add|merge)n variant when possible.

Modified files are:
   - modules/proxy/mod_proxy.c
   - modules/generators/mod_status.c
   - modules/session/mod_session.c

The first 2 are trivial.

For the last one, I have modified the pool used. Why use the request pool and
then making a copy within the session pool ? Why not directly allocate within
the session pool and avoid the copy. The later is what the patch does.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

DO NOT REPLY [Bug 51394] Code clean up (use apr_table_(set|add|merge)n variant when possible) #3

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51394

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

DO NOT REPLY [Bug 51394] Code clean up (use apr_table_(set|add|merge)n variant when possible) #3

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51394

Stefan Fritsch <sf...@sfritsch.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Stefan Fritsch <sf...@sfritsch.de> 2011-06-19 18:50:45 UTC ---
committed in r1137413, thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org