[GitHub] [apisix] membphis commented on a change in pull request #2395: improve: refactor apisix command line tool

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#discussion_r509027656



##########
File path: .luacheckrc
##########
@@ -2,3 +2,6 @@ std = "ngx_lua"
 unused_args = false
 redefined = false
 max_line_length = 100
+exclude_files = {
+    "apisix/cmd/ngx_tpl.lua",

Review comment:
       `cmd` -> `cli`
   
   @tokers What do you think?

##########
File path: apisix/cmd/env.lua
##########
@@ -0,0 +1,77 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local util = require "apisix.cmd.util"

Review comment:
       code style: `require("apisix.cmd.util")`

##########
File path: rockspec/apisix-master-0.rockspec
##########
@@ -20,8 +20,8 @@ version = "master-0"
 supported_platforms = {"linux", "macosx"}
 
 source = {
-    url = "git://github.com/apache/apisix",
-    branch = "master",
+    url = "git://github.com/tokers/apisix",
+    branch = "improve/cmd_refactoring",

Review comment:
       why we need to change this?

##########
File path: apisix/cmd/env.lua
##########
@@ -0,0 +1,77 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local util = require "apisix.cmd.util"

Review comment:
       and please fix similar points




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org