You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Ken Howe <kh...@pivotal.io> on 2016/05/17 17:22:38 UTC
Review Request 47479: GEODE-1296: change conditional in getRawBytes
to assert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47479/
-----------------------------------------------------------
Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Sai Boorlagadda.
Repository: geode
Description
-------
Made suggested change to getRawBytes. Updated correspondiong unit test.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java c2066b4a098ffb676ba31d7be244cf74ec9923d0
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java 23d72f532843ec0904e78b823a02d43b3cad1c74
Diff: https://reviews.apache.org/r/47479/diff/
Testing
-------
precheckin
Thanks,
Ken Howe
Re: Review Request 47479: GEODE-1296: change conditional in
getRawBytes to assert
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47479/#review133580
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On May 17, 2016, 10:22 a.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47479/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 10:22 a.m.)
>
>
> Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Made suggested change to getRawBytes. Updated correspondiong unit test.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java c2066b4a098ffb676ba31d7be244cf74ec9923d0
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java 23d72f532843ec0904e78b823a02d43b3cad1c74
>
> Diff: https://reviews.apache.org/r/47479/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Ken Howe
>
>
Re: Review Request 47479: GEODE-1296: change conditional in
getRawBytes to assert
Posted by Scott Jewell <sj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47479/#review134642
-----------------------------------------------------------
Ship it!
Ship It!
- Scott Jewell
On May 17, 2016, 5:22 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47479/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 5:22 p.m.)
>
>
> Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Made suggested change to getRawBytes. Updated correspondiong unit test.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java c2066b4a098ffb676ba31d7be244cf74ec9923d0
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java 23d72f532843ec0904e78b823a02d43b3cad1c74
>
> Diff: https://reviews.apache.org/r/47479/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Ken Howe
>
>
Re: Review Request 47479: GEODE-1296: change conditional in
getRawBytes to assert
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47479/#review134644
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On May 17, 2016, 5:22 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47479/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 5:22 p.m.)
>
>
> Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Made suggested change to getRawBytes. Updated correspondiong unit test.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java c2066b4a098ffb676ba31d7be244cf74ec9923d0
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java 23d72f532843ec0904e78b823a02d43b3cad1c74
>
> Diff: https://reviews.apache.org/r/47479/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Ken Howe
>
>