You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2024/09/14 11:49:47 UTC

[PR] Quote QuickJS path [couchdb]

nickva opened a new pull request, #5244:
URL: https://github.com/apache/couchdb/pull/5244

   We used to quote the spawnkiller path like this to handle spaces in paths:
   
   ```
    "\"" ++ filename:join(PrivDir, "couchspawnkillable") ++ "\""
   ```
   
   So we stick with the same pattern here as well for QuickJS path.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Quote QuickJS path [couchdb]

Posted by "nickva (via GitHub)" <gi...@apache.org>.

nickva merged PR #5244:
URL: https://github.com/apache/couchdb/pull/5244


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Quote QuickJS path [couchdb]

Posted by "nickva (via GitHub)" <gi...@apache.org>.

nickva commented on PR #5244:
URL: https://github.com/apache/couchdb/pull/5244#issuecomment-2350986682

   I had forgotten to update the tests. Now I fixed them to use open_port command just like couch_os_proc does, so the test is close to the code we ship. Also, instead of the tests looking through the output I look at the exit code.
   
   https://github.com/apache/couchdb/blob/902d973c3fc9d6c4ab1c3eb5743d517bfbfbb1a7/src/couch/src/couch_os_process.erl#L137


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org