[GitHub] rabbah commented on a change in pull request #2345: Add the support to install the binaries from the new repo

[gi...@git.apache.org]

rabbah commented on a change in pull request #2345: Add the support to install the binaries from the new repo
URL: https://github.com/apache/incubator-openwhisk/pull/2345#discussion_r121834338
 
 

 ##########
 File path: ansible/group_vars/all
 ##########
 @@ -228,3 +229,46 @@ catalog_repos:
     location: "{{ openwhisk_home }}/../openwhisk-catalog"
     version: "HEAD"
     repo_update: "no"
+
+openwhisk_cli_tag: "{{ lookup('ini', 'git_tag section=openwhisk-cli file={{ openwhisk_home }}/ansible/files/package-versions.ini') }}"
+
+# The openwhisk_cli is used to determine how to install the OpenWhisk CLI. The
+# installation_mode can be specified into two modes: remote and local.
+# The mode remote means to download the available binaries from the releases page
+# of the official openwhisk cli repository. The mode local means to get the binaries
+# from a local directory. The default value for openwhisk is remote.
+#
+# The name specifies the package name of the binaries in remote mode.
+#
+# The dest_name specifies the package name of the binaries in Nginx in remote mode.
+#
+# The location specifies the official website where Openwhisk CLI is hosted in
+# remote mode or location to save the binaries of the OpenWhisk CLI in local mode.
+#
+
+openwhisk_cli:
 
 Review comment:
   simply changing the setting to use local vs remote did not work.
   it seems that local mode is wrt the path to the binary but the build path is from the cli repo not this repo; and the cli repo will not deposit the binary in this path.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services