You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "bob mcwhirter (JIRA)" <be...@incubator.apache.org> on 2004/11/02 03:57:32 UTC

[jira] Created: (BEEHIVE-54) Patch for MantisTask to play friend with a mobile ${basedir}/$pwd

Patch for MantisTask to play friend with a mobile ${basedir}/$pwd
-----------------------------------------------------------------

         Key: BEEHIVE-54
         URL: http://nagoya.apache.org/jira/browse/BEEHIVE-54
     Project: Beehive
        Type: Improvement
  Components: Build, Controls  
    Reporter: bob mcwhirter


MantisTask assumes that ${basedir} is equal to $PWD, which isn't always the case.

Diff that mixes in a hearty does of getProject().getBaseDir() into the new File(...) calls within the task.

This patch enables my build changes to run the control tests as part of the build nicely now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-54) Patch for MantisTask to play friend with a mobile ${basedir}/$pwd

Posted by "James Song (JIRA)" <be...@incubator.apache.org>.
     [ http://nagoya.apache.org/jira/browse/BEEHIVE-54?page=comments#action_55020 ]
     
James Song commented on BEEHIVE-54:
-----------------------------------

changes made by r56407 is reverted by r56560.
Reasons:
The proposed change will limit usability of MantisTask by only allowing user to pass relative path for srcdir and srcgen, while the original code provide more flexibility by allowing user to pass fullpath for srcdir and srcgen.

User could still redirect mantis output by passing the right path for srcdir and srcgen.

> Patch for MantisTask to play friend with a mobile ${basedir}/$pwd
> -----------------------------------------------------------------
>
>          Key: BEEHIVE-54
>          URL: http://nagoya.apache.org/jira/browse/BEEHIVE-54
>      Project: Beehive
>         Type: Improvement
>   Components: Build, Controls
>     Reporter: bob mcwhirter
>     Assignee: James Song
>  Attachments: MantisTask.diff
>
> MantisTask assumes that ${basedir} is equal to $PWD, which isn't always the case.
> Diff that mixes in a hearty does of getProject().getBaseDir() into the new File(...) calls within the task.
> This patch enables my build changes to run the control tests as part of the build nicely now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (BEEHIVE-54) Patch for MantisTask to play friend with a mobile ${basedir}/$pwd

Posted by "bob mcwhirter (JIRA)" <be...@incubator.apache.org>.
     [ http://nagoya.apache.org/jira/browse/BEEHIVE-54?page=history ]

bob mcwhirter updated BEEHIVE-54:
---------------------------------

    Attachment: MantisTask.diff

diff as promised

> Patch for MantisTask to play friend with a mobile ${basedir}/$pwd
> -----------------------------------------------------------------
>
>          Key: BEEHIVE-54
>          URL: http://nagoya.apache.org/jira/browse/BEEHIVE-54
>      Project: Beehive
>         Type: Improvement
>   Components: Build, Controls
>     Reporter: bob mcwhirter
>  Attachments: MantisTask.diff
>
> MantisTask assumes that ${basedir} is equal to $PWD, which isn't always the case.
> Diff that mixes in a hearty does of getProject().getBaseDir() into the new File(...) calls within the task.
> This patch enables my build changes to run the control tests as part of the build nicely now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Closed: (BEEHIVE-54) Patch for MantisTask to play friend with a mobile ${basedir}/$pwd

Posted by "James Song (JIRA)" <be...@incubator.apache.org>.
     [ http://nagoya.apache.org/jira/browse/BEEHIVE-54?page=history ]
     
James Song closed BEEHIVE-54:
-----------------------------


by r56560, MantisTask is reversed, checkin.tests pass.

> Patch for MantisTask to play friend with a mobile ${basedir}/$pwd
> -----------------------------------------------------------------
>
>          Key: BEEHIVE-54
>          URL: http://nagoya.apache.org/jira/browse/BEEHIVE-54
>      Project: Beehive
>         Type: Improvement
>   Components: Build, Controls
>     Reporter: bob mcwhirter
>     Assignee: James Song
>  Attachments: MantisTask.diff
>
> MantisTask assumes that ${basedir} is equal to $PWD, which isn't always the case.
> Diff that mixes in a hearty does of getProject().getBaseDir() into the new File(...) calls within the task.
> This patch enables my build changes to run the control tests as part of the build nicely now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-54) Patch for MantisTask to play friend with a mobile ${basedir}/$pwd

Posted by "James Song (JIRA)" <be...@incubator.apache.org>.
     [ http://nagoya.apache.org/jira/browse/BEEHIVE-54?page=history ]
     
James Song resolved BEEHIVE-54:
-------------------------------

    Resolution: Fixed

Fix submitted by r56407, all drt tests pass.

> Patch for MantisTask to play friend with a mobile ${basedir}/$pwd
> -----------------------------------------------------------------
>
>          Key: BEEHIVE-54
>          URL: http://nagoya.apache.org/jira/browse/BEEHIVE-54
>      Project: Beehive
>         Type: Improvement
>   Components: Controls, Build
>     Reporter: bob mcwhirter
>     Assignee: James Song
>  Attachments: MantisTask.diff
>
> MantisTask assumes that ${basedir} is equal to $PWD, which isn't always the case.
> Diff that mixes in a hearty does of getProject().getBaseDir() into the new File(...) calls within the task.
> This patch enables my build changes to run the control tests as part of the build nicely now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (BEEHIVE-54) Patch for MantisTask to play friend with a mobile ${basedir}/$pwd

Posted by "Zach Smith (JIRA)" <be...@incubator.apache.org>.
     [ http://nagoya.apache.org/jira/browse/BEEHIVE-54?page=history ]

Zach Smith reassigned BEEHIVE-54:
---------------------------------

    Assign To: James Song

> Patch for MantisTask to play friend with a mobile ${basedir}/$pwd
> -----------------------------------------------------------------
>
>          Key: BEEHIVE-54
>          URL: http://nagoya.apache.org/jira/browse/BEEHIVE-54
>      Project: Beehive
>         Type: Improvement
>   Components: Build, Controls
>     Reporter: bob mcwhirter
>     Assignee: James Song
>  Attachments: MantisTask.diff
>
> MantisTask assumes that ${basedir} is equal to $PWD, which isn't always the case.
> Diff that mixes in a hearty does of getProject().getBaseDir() into the new File(...) calls within the task.
> This patch enables my build changes to run the control tests as part of the build nicely now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira