You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "kz930 (via GitHub)" <gi...@apache.org> on 2026/08/27 22:30:18 UTC
[PR] feat(huggingface): keep the row on an empty petal measurement [texera]
kz930 opened a new pull request, #8057:
URL: https://github.com/apache/texera/pull/8057
### What changes were proposed in this PR?
The operator puts the two petal values straight into a numpy array and standardizes them, so an empty cell reaches the subtraction as a `None` and ends the run with `unsupported operand type(s) for -: 'NoneType' and 'float'`, naming neither the column nor a way out. Nothing in the configuration can exclude the row.
It now answers the empty cell the way the three other operators in the group already do: keep the row, leave the prediction columns empty. Those three read a text column, which is why #7569 did not reach this one, and it was left as the only operator in the Hugging Face group that ends the run on a value the model was never given.
### Any related issues, documentation, discussions?
Closes #8056. The same answer the three text operators were given in #7569.
### How was this PR tested?
`HuggingFaceIrisLogisticRegressionOpDescSpec` pins the guard in the generated code; removing it turns that test red. `WorkflowOperator/test` passes: 2391 tests.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(huggingface): keep the row on an empty petal measurement [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #8057:
URL: https://github.com/apache/texera/pull/8057#issuecomment-5446037127
/request-review @carloea2 @aglinxinyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(huggingface): keep the row on an empty petal measurement [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8057:
URL: https://github.com/apache/texera/pull/8057#issuecomment-5445974947
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@carloea2`, `@aglinxinyuan`
You can notify them by mentioning `@carloea2`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(huggingface): keep the row on an empty petal measurement [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #8057:
URL: https://github.com/apache/texera/pull/8057#issuecomment-5516616058
Superseded by #8348, which carries this change together with the rest of its family so the set can be reviewed as one. Closing in favour of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(huggingface): keep the row on an empty petal measurement [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #8057:
URL: https://github.com/apache/texera/pull/8057#issuecomment-5458399146
@aglinxinyuan May you take a look at this PR please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(huggingface): keep the row on an empty petal measurement [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 closed pull request #8057: feat(huggingface): keep the row on an empty petal measurement
URL: https://github.com/apache/texera/pull/8057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(huggingface): keep the row on an empty petal measurement [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8057:
URL: https://github.com/apache/texera/pull/8057#issuecomment-5446002265
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8057?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.42%. Comparing base ([`646e460`](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ce96458`](https://app.codecov.io/gh/apache/texera/commit/ce964589035d7b3b05d9c6adfec916a42d3f86cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8057 +/- ##
=========================================
Coverage 93.42% 93.42%
Complexity 4703 4703
=========================================
Files 1180 1180
Lines 47766 47766
Branches 5321 5321
=========================================
Hits 44623 44623
Misses 1699 1699
Partials 1444 1444
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [646e460](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.58% <ø> (ø)` | | Carriedforward from [646e460](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [646e460](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.73% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.46% <ø> (ø)` | | Carriedforward from [646e460](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `95.89% <ø> (ø)` | | Carriedforward from [646e460](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.78% <ø> (ø)` | | Carriedforward from [646e460](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [646e460](https://app.codecov.io/gh/apache/texera/commit/646e460838c568dc421042ac8bcd95aa534aa118?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8057?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(huggingface): keep the row on an empty petal measurement [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8057:
URL: https://github.com/apache/texera/pull/8057#issuecomment-5446025043
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 5 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `646e460` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33122767371)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 484 | 0.295 | 19,485/28,666/28,666 us | 🔴 -16.7% / 🔴 +104.6% |
| ⚪ | bs=100 sw=10 sl=64 | 1,206 | 0.736 | 82,483/93,873/93,873 us | ⚪ within ±5% / 🟢 -8.7% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,405 | 0.857 | 710,391/746,971/746,971 us | ⚪ within ±5% / 🟢 -21.4% |
<details><summary>Baseline details</summary>
Latest main `646e460` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 484 tuples/sec | 580 tuples/sec | 893.99 tuples/sec | -16.6% | -45.9% |
| bs=10 sw=10 sl=64 | MB/s | 0.295 MB/s | 0.354 MB/s | 0.546 MB/s | -16.7% | -45.9% |
| bs=10 sw=10 sl=64 | p50 | 19,485 us | 17,040 us | 11,176 us | +14.3% | +74.3% |
| bs=10 sw=10 sl=64 | p95 | 28,666 us | 25,172 us | 14,009 us | +13.9% | +104.6% |
| bs=10 sw=10 sl=64 | p99 | 28,666 us | 25,172 us | 16,898 us | +13.9% | +69.6% |
| bs=100 sw=10 sl=64 | throughput | 1,206 tuples/sec | 1,195 tuples/sec | 1,157 tuples/sec | +0.9% | +4.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.736 MB/s | 0.729 MB/s | 0.706 MB/s | +1.0% | +4.2% |
| bs=100 sw=10 sl=64 | p50 | 82,483 us | 83,777 us | 88,763 us | -1.5% | -7.1% |
| bs=100 sw=10 sl=64 | p95 | 93,873 us | 96,985 us | 95,096 us | -3.2% | -1.3% |
| bs=100 sw=10 sl=64 | p99 | 93,873 us | 96,985 us | 102,854 us | -3.2% | -8.7% |
| bs=1000 sw=10 sl=64 | throughput | 1,405 tuples/sec | 1,422 tuples/sec | 1,187 tuples/sec | -1.2% | +18.4% |
| bs=1000 sw=10 sl=64 | MB/s | 0.857 MB/s | 0.868 MB/s | 0.724 MB/s | -1.3% | +18.3% |
| bs=1000 sw=10 sl=64 | p50 | 710,391 us | 705,602 us | 874,968 us | +0.7% | -18.8% |
| bs=1000 sw=10 sl=64 | p95 | 746,971 us | 761,983 us | 917,815 us | -2.0% | -18.6% |
| bs=1000 sw=10 sl=64 | p99 | 746,971 us | 761,983 us | 949,868 us | -2.0% | -21.4% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,413.31,200,128000,484,0.295,19484.51,28666.47,28666.47
1,100,10,64,20,1658.69,2000,1280000,1206,0.736,82482.65,93872.79,93872.79
2,1000,10,64,20,14236.97,20000,12800000,1405,0.857,710391.46,746970.86,746970.86
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org