You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/03 07:52:20 UTC
[GitHub] [commons-lang] kanaksony opened a new pull request #667: [LANG-1622] Corrected reference to right methods.
kanaksony opened a new pull request #667:
URL: https://github.com/apache/commons-lang/pull/667
Corrected:
StringUtils.isNumericSpace incorrectly refer to isNumeric
BooleanUtils.toBoolean incorrectly refer to toBooleanObject
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #667: [LANG-1622] Corrected reference to right methods.
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #667:
URL: https://github.com/apache/commons-lang/pull/667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kanaksony commented on a change in pull request #667: [LANG-1622] Corrected reference to right methods.
Posted by GitBox <gi...@apache.org>.
kanaksony commented on a change in pull request #667:
URL: https://github.com/apache/commons-lang/pull/667#discussion_r535364671
##########
File path: src/main/java/org/apache/commons/lang3/BooleanUtils.java
##########
@@ -548,9 +548,9 @@ public static Boolean toBooleanObject(final int value, final int trueValue, fina
* if unboxed to a {@code boolean}.</p>
*
* <pre>
- * BooleanUtils.toBoolean(Integer.valueOf(0)) = Boolean.FALSE
Review comment:
@garydgregory I understand you merged PR 668 as it was reported by original reporter and had fix too. If you will review my PR, I have corrected similar issue thing on other lines too that's from L551-L553.
Should I make another PR for same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org