[GitHub] [superset] villebro commented on pull request #23016: fix(embedded): successfully load embedded dashboard as expected

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on PR #23016:
URL: https://github.com/apache/superset/pull/23016#issuecomment-1423774242

   Thanks for this improvement @marlomorales - I think the change makes sense, but to future proof this against regressions, it would be great if we could add an integration test here, as I consider this fairly critical functionality that I'd hate to see break in the future due to incomplete test coverage. Let me know if you need help and I'll do my best to carve out some time to provide assistance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org