You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/09/06 18:00:02 UTC

[GitHub] [helix] micahstubbs commented on a diff in pull request #2204: 2203/helix front storybook visual tests

micahstubbs commented on code in PR #2204:
URL: https://github.com/apache/helix/pull/2204#discussion_r964017100


##########
helix-front/angular.json:
##########
@@ -5,28 +5,28 @@
   "projects": {
     "helix-front": {
       "root": "",
-      "sourceRoot": "client",
+      "sourceRoot": "src",

Review Comment:
   The majority of the diff is related to this change, which was required by storybook.
   
   Error message:
   
   ```bash
   The client/assets asset path must start with the project source root.
   ```
   
   https://github.com/apache/helix/issues/2203#issuecomment-1236168591
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org