[GitHub] [accumulo] ctubbsii commented on a change in pull request #1531: Bump ZooKeeper dependency to 3.5.7

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1531: Bump ZooKeeper dependency to 3.5.7
URL: https://github.com/apache/accumulo/pull/1531#discussion_r384778200
 
 

 ##########
 File path: test/src/test/java/org/apache/accumulo/test/fate/zookeeper/ZooLockTest.java
 ##########
 @@ -274,42 +274,43 @@ public void testUnexpectedEvent() throws Exception {
     String parent = "/zltest-" + this.hashCode() + "-l" + pdCount.incrementAndGet();
 
     ConnectedWatcher watcher = new ConnectedWatcher();
-    ZooKeeper zk = new ZooKeeper(accumulo.getZooKeepers(), 30000, watcher);
-    zk.addAuthInfo("digest", "accumulo:secret".getBytes(UTF_8));
+    try (ZooKeeper zk = new ZooKeeper(accumulo.getZooKeepers(), 30000, watcher)) {
 
 Review comment:
   I think these might be the only places we could use try-with-resources (I only fixed these because they generated warnings). But yes, separate issue, if there's anything else to be done with this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services