[GitHub] [kafka] guozhangwang commented on a change in pull request #9667: MINOR: Do not print log4j for memberId required

[GitBox <gi...@apache.org>]

guozhangwang commented on a change in pull request #9667:
URL: https://github.com/apache/kafka/pull/9667#discussion_r536282550



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -465,7 +465,11 @@ boolean joinGroupIfNeeded(final Timer timer) {
                 }
             } else {
                 final RuntimeException exception = future.exception();
-                log.info("Rebalance failed.", exception);
+
+                if (!(exception instanceof MemberIdRequiredException)) {

Review comment:
       I think I agree with you: it is a bit redundant. I think originally it is because this future may contain the error that is either from join-response or from sync-response, but at the moment both errors are logged inside the Join/SyncGroupHandler anyways. Just to maintain compatibility in case some trouble shooting scenarios are dependent on this summary entry for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org