[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4410: [INLONG-2432][Manager] Change password encrypted for Hive sink

[GitBox <gi...@apache.org>]

healchow commented on code in PR #4410:
URL: https://github.com/apache/incubator-inlong/pull/4410#discussion_r884148519


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/hive/HiveSinkDTO.java:
##########
@@ -92,10 +94,15 @@ public class HiveSinkDTO {
      * Get the dto instance from the request
      */
     public static HiveSinkDTO getFromRequest(HiveSinkRequest request) {
+        Base64 bas64 = new Base64();

Review Comment:
   Could we set the instance of Base64 as the global variable?



##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/hive/HiveSinkDTO.java:
##########
@@ -152,4 +159,13 @@ public static HiveTableInfo getHiveTableInfo(HiveSinkDTO hiveInfo, List<HiveColu
         return tableInfo;
     }
 
+    private HiveSinkDTO decodePassword() {
+        if (this.password != null) {

Review Comment:
   Please use the `StringUtils.isNotBlank()` method for null checks, tks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org