You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/23 03:40:03 UTC
Review Request 56965: Hive 2: "insert udf" opens empty drop down
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56965/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20127
https://issues.apache.org/jira/browse/AMBARI-20127
Repository: ambari
Description
-------
- Added condition of disabling the "Insert UDF" button when there is no UDF.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 64f38ab
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 4fd3ce201
Diff: https://reviews.apache.org/r/56965/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56965: Hive 2: "insert udf" opens empty drop down
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56965/#review166475
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 23, 2017, 3:40 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56965/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 3:40 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20127
> https://issues.apache.org/jira/browse/AMBARI-20127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added condition of disabling the "Insert UDF" button when there is no UDF.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 64f38ab
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 4fd3ce201
>
> Diff: https://reviews.apache.org/r/56965/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56965: Hive 2: "insert udf" opens empty drop down
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56965/#review166472
-----------------------------------------------------------
Ship it!
Ship It!
- Abhishek Kumar
On Feb. 23, 2017, 3:40 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56965/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 3:40 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20127
> https://issues.apache.org/jira/browse/AMBARI-20127
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added condition of disabling the "Insert UDF" button when there is no UDF.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 64f38ab
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 4fd3ce201
>
> Diff: https://reviews.apache.org/r/56965/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>