You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2017/10/03 00:08:01 UTC

[jira] [Comment Edited] (GUACAMOLE-384) Guacd crashes in buffer.c during stress test

    [ https://issues.apache.org/jira/browse/GUACAMOLE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189097#comment-16189097 ] 

Michael Jumper edited comment on GUACAMOLE-384 at 10/3/17 12:07 AM:
--------------------------------------------------------------------

I'm working on this bug. I think there is a problem here causing the crash.

{code:none}
(gdb) frame 0
#0  0x00002aaaafb69600 in guac_terminal_buffer_get_row (buffer=0x2aaab801e900, row=0, width=1)
    at buffer.c:108
108                 *(first++) = buffer->default_character;
(gdb) p buffer_row->length
$159 = -1207959432
(gdb) frame 7
#7  0x00002aaaafb61421 in ssh_client_thread (data=0x2aaab400ad70) at ssh.c:342
342                 int written = guac_terminal_write(ssh_client->term, buffer, bytes_read);
(gdb) p ssh_client->term->buffer->rows[0]
$160 = {characters = 0x2aaab8000078, length = -1207959432, available = 10922}
{code}


was (Author: sanhex):
I'm working on this bug. I think there is a problem here causing the crash.

(gdb) frame 0
#0  0x00002aaaafb69600 in guac_terminal_buffer_get_row (buffer=0x2aaab801e900, row=0, width=1)
    at buffer.c:108
108                 *(first++) = buffer->default_character;
(gdb) p buffer_row->length
$159 = -1207959432
(gdb) frame 7
#7  0x00002aaaafb61421 in ssh_client_thread (data=0x2aaab400ad70) at ssh.c:342
342                 int written = guac_terminal_write(ssh_client->term, buffer, bytes_read);
(gdb) p ssh_client->term->buffer->rows[0]
$160 = {characters = 0x2aaab8000078, length = -1207959432, available = 10922}

> Guacd crashes in buffer.c during stress test 
> ---------------------------------------------
>
>                 Key: GUACAMOLE-384
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-384
>             Project: Guacamole
>          Issue Type: Bug
>          Components: Terminal
>    Affects Versions: 0.9.12-incubating
>         Environment: GNU/Linux x86_64
>            Reporter: Phillip Arcuri
>            Priority: Blocker
>
> In a stress test we kick off an SSH session every second.  The session does a minimal amount of work and exits after a few seconds.  A ps -ef shows we have 2 to 6 instances running at one time.  About 1 in 10 of the instances cores with corrupted buffer data at line buffer.c:108.:
> (gdb) p *buffer
> $2 = {default_character = {value = -1269703408, attributes = {bold = 170, reverse = 42, cursor = false, underscore = false, foreground = 0,
>       background = 0}, width = -1269422328}, rows = 0x2aaab456fa30, top = 686, length = 0, available = 686}
> As an aside I also see roughly 1 in 100 instances become a zombie process hung in pthread_join.  Doubt that is related, but thought I'd mention it.
> This is a blocker for our deployment of a guacamole-enabled feature-set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)