You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/02 15:54:46 UTC
[GitHub] [incubator-superset] etr2460 opened a new issue #10232: Welcome page pagination is inconsistent
etr2460 opened a new issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232
The pagination of dashboards on the welcome page doesn't have a consistent number of dashboards per page, and the record count isn't sequential. There record counts also seem to flicker and update to different numbers as the page loads (e.g. displaying 1-11, then updating to 1-15 once items render)
### Expected results
Each page to have the same number of items, record counting to be sequential (e.g. first page is 1-10, 2nd is 11-20, 3rd is 21-30, etc)
#### Screenshots
<img width="1192" alt="Screen Shot 2020-07-02 at 8 49 25 AM" src="https://user-images.githubusercontent.com/7409244/86380810-657fec80-bc41-11ea-987f-7fdee435c850.png">
<img width="1190" alt="Screen Shot 2020-07-02 at 8 49 33 AM" src="https://user-images.githubusercontent.com/7409244/86380816-67e24680-bc41-11ea-921b-5315cc19adbc.png">
#### How to reproduce the bug
Paginate on the welcome page
### Environment
(please complete the following information):
- superset version: `master`
We have not yet enabled React List Views in our environment
to: @nytai, I think you were working on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #10232: Welcome page pagination is inconsistent
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232#issuecomment-653163592
I think this may be related to a bug I currently fixed on FAB related with m-m relations on lists. The amount of owners are counted has records also, will publish an FAB 3 RC2 tomorrow if it's not too urgent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10232: Welcome page pagination is inconsistent
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232#issuecomment-653089744
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #10232: Welcome page pagination is inconsistent
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232#issuecomment-653124099
@etr2460 I have noticed some weirdness with the record counts being inconsistent, I'll look into that now. To be clear, you have "whited-out" the dashboard and creator columns in the screenshots and that isn't a bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on issue #10232: Welcome page pagination is inconsistent
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232#issuecomment-653126405
I've gotten similar bug reports from our users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #10232: Welcome page pagination is inconsistent
Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232#issuecomment-653844349
@nytai: correct, I whited out the dashboard and creator columns to prevent exposing sensitive data.
@dpgaspar: thanks for the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed issue #10232: Welcome page pagination is inconsistent
Posted by GitBox <gi...@apache.org>.
dpgaspar closed issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #10232: Welcome page pagination is inconsistent
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10232:
URL: https://github.com/apache/incubator-superset/issues/10232#issuecomment-653148920
I'm also confused where the 10 records per page is coming from. In the code it's currently set to 25, https://github.com/preset-io/incubator-superset/blob/master/superset-frontend/src/welcome/DashboardTable.jsx#L28
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org