You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by pe...@apache.org on 2006/12/10 23:24:31 UTC
svn commit: r485287 - in /ant/core/trunk: WHATSNEW
src/main/org/apache/tools/ant/ComponentHelper.java
Author: peterreilly
Date: Sun Dec 10 14:24:29 2006
New Revision: 485287
URL: http://svn.apache.org/viewvc?view=rev&rev=485287
Log:
Fix for Bugzilla 41049.
This modification stops ComponentHelper from keeping track
of tasks so that they can be invalidated if the task
definition changes. This is not needed anymore as
changes in UnknownElement processing in ant 1.7 mean
that UEs are kept in the Target task/type list, not the
resultant tasks.
Modified:
ant/core/trunk/WHATSNEW
ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java
Modified: ant/core/trunk/WHATSNEW
URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?view=diff&rev=485287&r1=485286&r2=485287
==============================================================================
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Sun Dec 10 14:24:29 2006
@@ -39,6 +39,9 @@
* XmlProperty overrides previously set property value when handling duplicate
elements. Bugzilla 41080.
+* Having many tasks causes OOM.
+ Bugzilla 41049.
+
Other changes:
--------------
Modified: ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java?view=diff&rev=485287&r1=485286&r2=485287
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/ComponentHelper.java Sun Dec 10 14:24:29 2006
@@ -18,7 +18,6 @@
package org.apache.tools.ant;
-import java.lang.ref.WeakReference;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
import java.lang.reflect.InvocationTargetException;
@@ -34,7 +33,6 @@
import java.util.Properties;
import java.util.Set;
import java.util.Stack;
-import java.util.Vector;
import org.apache.tools.ant.taskdefs.Typedef;
import org.apache.tools.ant.taskdefs.Definer;
@@ -83,13 +81,6 @@
private String antLibCurrentUri = null;
/**
- * Map from task names to vectors of created tasks
- * (String to Vector of Task). This is used to invalidate tasks if
- * the task definition changes.
- */
- private Hashtable createdTasks = new Hashtable();
-
- /**
* this does not appear to be used anywhere in the Ant codebase
* even via its accessors
*/
@@ -229,7 +220,6 @@
task.setTaskName(ue.getTaskName());
task.setOwningTarget(ue.getOwningTarget());
task.init();
- addCreatedTask(componentType, task);
}
return component;
}
@@ -285,9 +275,7 @@
* Attempting to override an existing definition with an
* equivalent one (i.e. with the same classname) results in
* a verbose log message. Attempting to override an existing definition
- * with a different one results in a warning log message and
- * invalidates any tasks which have already been created with the
- * old definition.
+ * with a different one results in a warning log message.
*
* @param taskName The name of the task to add.
* Must not be <code>null</code>.
@@ -456,12 +444,9 @@
}
/**
- * Creates a new instance of a task, adding it to a list of
- * created tasks for later invalidation. This causes all tasks
- * to be remembered until the containing project is removed
+ * Creates a new instance of a task.
*
* Called from Project.createTask(), which can be called by tasks.
- * The method should be deprecated, as it doesn't support ns and libs.
*
* @param taskType The name of the task to create an instance of.
* Must not be <code>null</code>.
@@ -481,15 +466,11 @@
org.apache.tools.ant.taskdefs.Property.class);
task = createNewTask(taskType);
}
- if (task != null) {
- addCreatedTask(taskType, task);
- }
return task;
}
/**
- * Creates a new instance of a task. This task is not
- * cached in the createdTasks list.
+ * Creates a new instance of a task.
* @since ant1.6
* @param taskType The name of the task to create an instance of.
* Must not be <code>null</code>.
@@ -526,53 +507,6 @@
}
/**
- * Keeps a record of all tasks that have been created so that they
- * can be invalidated if a new task definition overrides the current one.
- *
- * @param type The name of the type of task which has been created.
- * Must not be <code>null</code>.
- *
- * @param task The freshly created task instance.
- * Must not be <code>null</code>.
- */
- private void addCreatedTask(String type, Task task) {
- synchronized (createdTasks) {
- Vector v = (Vector) createdTasks.get(type);
- if (v == null) {
- v = new Vector();
- createdTasks.put(type, v);
- }
- v.addElement(new WeakReference(task));
- }
- }
-
- /**
- * Mark tasks as invalid which no longer are of the correct type
- * for a given taskname.
- *
- * @param type The name of the type of task to invalidate.
- * Must not be <code>null</code>.
- */
- private void invalidateCreatedTasks(String type) {
- synchronized (createdTasks) {
- Vector v = (Vector) createdTasks.get(type);
- if (v != null) {
- Enumeration taskEnum = v.elements();
- while (taskEnum.hasMoreElements()) {
- WeakReference ref = (WeakReference) taskEnum.nextElement();
- Task t = (Task) ref.get();
- //being a weak ref, it may be null by this point
- if (t != null) {
- t.markInvalid();
- }
- }
- v.removeAllElements();
- createdTasks.remove(type);
- }
- }
- }
-
- /**
* Creates a new instance of a data type.
*
* @param typeName The name of the data type to create an instance of.
@@ -721,9 +655,6 @@
+ (isTask ? "task " : "datatype ") + name,
(def.similarDefinition(old, project))
? Project.MSG_VERBOSE : Project.MSG_WARN);
- if (isTask) {
- invalidateCreatedTasks(name);
- }
}
project.log(" +Datatype " + name + " " + def.getClassName(),
Project.MSG_DEBUG);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org