[GitHub] betodealmeida opened a new pull request #5084: Override time grain in annotations

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #5084: Override time grain in annotations
URL: https://github.com/apache/incubator-superset/pull/5084
 
 
   Allow overriding the time grain of time series annotations.
   
   The good news is that we've unified the granularity of Druid and SQLAlchemy, using ISO duration strings, so we can apply the time grain of a Druid time series to a SQLAlchemy time series annotation, and vice versa.
   
   The bad news is that this is currently a bit ugly because we don't know if the time series annotation has a SQLAlchemy or a Druid datasource. So we pass the current time grain in both `granularity` and `time_grain_sqla`. This only works if the SQLAlchemy datasource has a main temporal table configured.
   
   In the future we should unify this as a single parameter, IMHO.
   
   The screenshot below shows an annotation that was saved with hourly grain (`sqla_hourly`) being loaded with daily grain. Note the new checkbox, "Override time grain":
   
   <img width="1680" alt="screen shot 2018-05-25 at 12 46 32 pm" src="https://user-images.githubusercontent.com/1534870/40563650-67093dd4-601a-11e8-9dea-0946d7ce5d23.png">
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org