You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 18:17:32 UTC

[GitHub] [flink] rmetzger commented on a change in pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build

rmetzger commented on a change in pull request #13779:
URL: https://github.com/apache/flink/pull/13779#discussion_r512172920



##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -19,6 +19,8 @@
 
 source "$(dirname "$0")"/common_kubernetes.sh
 
+IMAGE_BUILD_RETRIES=3

Review comment:
       The reason is that I copy pasted the retry call from somewhere else, where this weird combo of variable and magic number was used.
   
   How about introducing a second variable the magic number? I like these variables just for the sake of self-documentation.
   WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org