You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/01/05 14:14:21 UTC

Review Request 41927: Changed `Statistics` to only provide total CPU usage.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41927/
-----------------------------------------------------------

Review request for mesos, Alexander Rojas and Till Toenshoff.


Bugs: MESOS-4280
    https://issues.apache.org/jira/browse/MESOS-4280


Repository: mesos


Description
-------

Changed `Statistics` to only provide total CPU usage.


Diffs
-----

  src/webui/master/static/js/services.js d41bc7142ae0182e25b2ae9dce960ee38ab22361 
  src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
  src/webui/master/static/slave_framework.html 90eff2f3b4de08f98283b27e1635ba23a855e488 

Diff: https://reviews.apache.org/r/41927/diff/


Testing
-------

With a linux machine:
sudo ./bin/mesos-local.sh &
./src/mesos-execute --master=IP_OF_MASTER:5050 --name=Foo --command="sleep 100"

Then visually navigating to http://IP_OF_MASTER:5050/#/slaves, selecting the slave and checking if "CPUs (Used / Allocated)" in "Frameworks" section changes while the sleep command is executed.


Thanks,

Jan Schlicht


Re: Review Request 41927: Changed `Statistics` to only provide total CPU usage.

Posted by Till Toenshoff <to...@me.com>.

> On Jan. 5, 2016, 1:41 p.m., Till Toenshoff wrote:
> > Ship It!

Thanks for describing your testing that well!


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41927/#review112846
-----------------------------------------------------------


On Jan. 5, 2016, 1:14 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41927/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 1:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4280
>     https://issues.apache.org/jira/browse/MESOS-4280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed `Statistics` to only provide total CPU usage.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/services.js d41bc7142ae0182e25b2ae9dce960ee38ab22361 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
>   src/webui/master/static/slave_framework.html 90eff2f3b4de08f98283b27e1635ba23a855e488 
> 
> Diff: https://reviews.apache.org/r/41927/diff/
> 
> 
> Testing
> -------
> 
> With a linux machine:
> sudo ./bin/mesos-local.sh &
> ./src/mesos-execute --master=IP_OF_MASTER:5050 --name=Foo --command="sleep 100"
> 
> Then visually navigating to http://IP_OF_MASTER:5050/#/slaves, selecting the slave and checking if "CPUs (Used / Allocated)" in "Frameworks" section changes while the sleep command is executed.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 41927: Changed `Statistics` to only provide total CPU usage.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41927/#review112846
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Jan. 5, 2016, 1:14 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41927/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 1:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-4280
>     https://issues.apache.org/jira/browse/MESOS-4280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed `Statistics` to only provide total CPU usage.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/services.js d41bc7142ae0182e25b2ae9dce960ee38ab22361 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
>   src/webui/master/static/slave_framework.html 90eff2f3b4de08f98283b27e1635ba23a855e488 
> 
> Diff: https://reviews.apache.org/r/41927/diff/
> 
> 
> Testing
> -------
> 
> With a linux machine:
> sudo ./bin/mesos-local.sh &
> ./src/mesos-execute --master=IP_OF_MASTER:5050 --name=Foo --command="sleep 100"
> 
> Then visually navigating to http://IP_OF_MASTER:5050/#/slaves, selecting the slave and checking if "CPUs (Used / Allocated)" in "Frameworks" section changes while the sleep command is executed.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>