[GitHub] [incubator-mxnet] mseth10 commented on issue #14403: Fix slice op issues #13760

[GitBox <gi...@apache.org>]

mseth10 commented on issue #14403: Fix slice op issues #13760
URL: https://github.com/apache/incubator-mxnet/pull/14403#issuecomment-473409149
 
 
   > There are so many if/else/elseif branches in this piece of code. I know it fixes the two cases you mentioned in the description. However, instead of patching, could you please find ways to simplify the logic to fix more general cases? If not, can you add comment to the end of each branch such as `// end of if (s < -1)` to make the code more readable.
   
   @apeforest Simplified the logic and refactored the code. Also added comments. Please review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services