svn commit: r1484376 - in /mahout/trunk: CHANGELOG math/src/main/java/org/apache/mahout/math/SparseMatrix.java math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java

[sm...@apache.org]

Author: smarthi
Date: Mon May 20 06:04:47 2013
New Revision: 1484376

URL: http://svn.apache.org/r1484376
Log:
MAHOUT-1221: SparseMatrix.viewRow is sometimes readonly

Modified:
    mahout/trunk/CHANGELOG
    mahout/trunk/math/src/main/java/org/apache/mahout/math/SparseMatrix.java
    mahout/trunk/math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java

Modified: mahout/trunk/CHANGELOG
URL: http://svn.apache.org/viewvc/mahout/trunk/CHANGELOG?rev=1484376&r1=1484375&r2=1484376&view=diff
==============================================================================
--- mahout/trunk/CHANGELOG (original)
+++ mahout/trunk/CHANGELOG Mon May 20 06:04:47 2013
@@ -2,6 +2,8 @@ Mahout Change Log
 
 Release 0.8 - unreleased
 
+  MAHOUT-1221: SparseMatrix.viewRow is sometimes readonly. (Maysam Yabandeh via smarthi)
+
 __MAHOUT-1219: Remove LSHSearcher from SearchQualityTest. It causes it to fail, but the failure is not very meaningful (dfilimon)
 
 __MAHOUT-1217: Nearest neighbor searchers sometimes fail to remove points: fix in FastProjectionSearch's searchFirst (dfilimon)

Modified: mahout/trunk/math/src/main/java/org/apache/mahout/math/SparseMatrix.java
URL: http://svn.apache.org/viewvc/mahout/trunk/math/src/main/java/org/apache/mahout/math/SparseMatrix.java?rev=1484376&r1=1484375&r2=1484376&view=diff
==============================================================================
--- mahout/trunk/math/src/main/java/org/apache/mahout/math/SparseMatrix.java (original)
+++ mahout/trunk/math/src/main/java/org/apache/mahout/math/SparseMatrix.java Mon May 20 06:04:47 2013
@@ -175,6 +175,7 @@ public class SparseMatrix extends Abstra
     Vector res = rowVectors.get(row);
     if (res == null) {
       res = new RandomAccessSparseVector(columnSize());
+      rowVectors.put(row, res);
     }
     return res;
   }

Modified: mahout/trunk/math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java
URL: http://svn.apache.org/viewvc/mahout/trunk/math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java?rev=1484376&r1=1484375&r2=1484376&view=diff
==============================================================================
--- mahout/trunk/math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java (original)
+++ mahout/trunk/math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java Mon May 20 06:04:47 2013
@@ -17,6 +17,8 @@
 
 package org.apache.mahout.math;
 
+import org.junit.Test;
+
 public final class TestSparseMatrix extends MatrixTest {
 
   @Override
@@ -30,4 +32,15 @@ public final class TestSparseMatrix exte
     return matrix;
   }
 
+  @Test
+  public void testViewRow() {
+    //create a matrix with an unassigned row 0
+    Matrix matrix = new SparseMatrix(1, 1);
+    Vector view = matrix.viewRow(0);
+    final double value = 1.23;
+    view.assign(value);
+    //test whether the update in the view is reflected in the matrix
+    assertEquals("Matrix value", view.getQuick(0), matrix.getQuick(0, 0), EPSILON);
+  }
+
 }