You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "wenbingshen (via GitHub)" <gi...@apache.org> on 2023/04/25 08:34:10 UTC
[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3938: drop invalid entryFormat arg from shell command
wenbingshen opened a new pull request, #3938:
URL: https://github.com/apache/bookkeeper/pull/3938
### Motivation
According to the configuration of ENTRY_FORMATTER_CLASS in the bookkeeper shell command, it will never take effect, we should remove it,
We can use -entryformat or configure in bookie config to take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3938: drop invalid entryFormat arg from shell command
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3938:
URL: https://github.com/apache/bookkeeper/pull/3938#issuecomment-1521711785
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT merged pull request #3938: drop invalid entryFormat arg from shell command
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT merged PR #3938:
URL: https://github.com/apache/bookkeeper/pull/3938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3938: drop invalid entryFormat arg from shell command
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3938:
URL: https://github.com/apache/bookkeeper/pull/3938#issuecomment-1541252495
> Will there be compatibility issues, will it be compatible with old usage? i'm a bit worried about this
@StevenLuMT I don't think there is an old compatibility issue here, because `ENTRY_FORMATTER_CLASS` is set as a jvm system property value, and It is not referenced anywhere in the bookkeeper's existing source code, even though the system the attribute has been configured, but it will not take effect. It is safe for us to delete it. PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3938: drop invalid entryFormat arg from shell command
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3938:
URL: https://github.com/apache/bookkeeper/pull/3938#issuecomment-1521628629
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org