You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 20:40:37 UTC

[GitHub] [airflow] eladkal opened a new issue #21597: replace hql references to sql in TrinoHook and PrestoHook

eladkal opened a new issue #21597:
URL: https://github.com/apache/airflow/issues/21597


   ### Body
   
   Both:
   https://github.com/apache/airflow/blob/main/airflow/providers/presto/hooks/presto.py
   https://github.com/apache/airflow/blob/main/airflow/providers/trino/hooks/trino.py
   
   uses terminology of `hql` we should change it to `sql`.
   The change needs to be backwards compatible. e.g deprecating hql with warning 
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed issue #21597: replace `hql` references to `sql` in `TrinoHook` and `PrestoHook`

Posted by GitBox <gi...@apache.org>.
eladkal closed issue #21597:
URL: https://github.com/apache/airflow/issues/21597


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] utkarsharma2 edited a comment on issue #21597: replace `hql` references to `sql` in `TrinoHook` and `PrestoHook`

Posted by GitBox <gi...@apache.org>.
utkarsharma2 edited a comment on issue #21597:
URL: https://github.com/apache/airflow/issues/21597#issuecomment-1042540961


   Hey @eladkal,  simply replacing `hql` with `sql` won't break backward compatibility, can you explain bit more?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] utkarsharma2 removed a comment on issue #21597: replace `hql` references to `sql` in `TrinoHook` and `PrestoHook`

Posted by GitBox <gi...@apache.org>.
utkarsharma2 removed a comment on issue #21597:
URL: https://github.com/apache/airflow/issues/21597#issuecomment-1042540961


   Hey @eladkal,  simply replacing `hql` with `sql` won't break backward compatibility, can you explain bit more?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] utkarsharma2 edited a comment on issue #21597: replace `hql` references to `sql` in `TrinoHook` and `PrestoHook`

Posted by GitBox <gi...@apache.org>.
utkarsharma2 edited a comment on issue #21597:
URL: https://github.com/apache/airflow/issues/21597#issuecomment-1042540961


   Hey @eladkal,  simply replacing `hql` with `sql` won't break backward compatibility. Can you explain bit more?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kazanzhy commented on issue #21597: replace `hql` references to `sql` in `TrinoHook` and `PrestoHook`

Posted by GitBox <gi...@apache.org>.
kazanzhy commented on issue #21597:
URL: https://github.com/apache/airflow/issues/21597#issuecomment-1040808001


   I'm working on a few other PRs but could take this issue if nobody else will take it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] utkarsharma2 commented on issue #21597: replace `hql` references to `sql` in `TrinoHook` and `PrestoHook`

Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on issue #21597:
URL: https://github.com/apache/airflow/issues/21597#issuecomment-1042540961


   Hey @eladkal,  simply replacing `hql` with `sql` won't break backward compatibility. Can you explain bit more about the backward compatibility?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org