[jira] [Comment Edited] (KAFKA-5098) KafkaProducer.send() blocks and generates TimeoutException if topic name has illegal char

["Ismael Juma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036327#comment-16036327 ] 

Ismael Juma edited comment on KAFKA-5098 at 6/4/17 4:36 PM:
------------------------------------------------------------

[~onurkaraman] correctly asked about the potential performance impact of doing this check for each producer record. I did some micro-benchmarking and it could be significant (particularly if the topic name is long). I reverted the change for now until we have a chance to verify its impact via `ProducerPerformance`.

I also submitted a PR that improves the performance of `Topic.validate()`:

https://github.com/apache/kafka/pull/3234


was (Author: ijuma):
[~onurkaraman] correctly asked about the potential performance impact of doing this check for each producer record. I did some micro-benchmarking and it could be significant (particularly if the topic name is long). I reverted the change for now until we have a chance to verify its impact via `ProducerPerformance`.

I also submitted a PR that improves the performance of `Topic.validate()`.

> KafkaProducer.send() blocks and generates TimeoutException if topic name has illegal char
> -----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5098
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5098
>             Project: Kafka
>          Issue Type: Bug
>          Components: producer 
>    Affects Versions: 0.10.2.0
>         Environment: Java client running against server using wurstmeister/kafka Docker image.
>            Reporter: Jeff Larsen
>            Assignee: huxihx
>             Fix For: 0.11.1.0
>
>
> The server is running with auto create enabled. If we try to publish to a topic with a forward slash in the name, the call blocks and we get a TimeoutException in the Callback. I would expect it to return immediately with an InvalidTopicException.
> There are other blocking issues that have been reported which may be related to some degree, but this particular cause seems unrelated.
> Sample code:
> {code}
> import org.apache.kafka.clients.producer.*;
> import java.util.*;
> public class KafkaProducerUnexpectedBlockingAndTimeoutException {
>   public static void main(String[] args) {
>     Properties props = new Properties();
>     props.put("bootstrap.servers", "kafka.example.com:9092");
>     props.put("key.serializer", "org.apache.kafka.common.serialization.StringSerializer");
>     props.put("value.serializer", "org.apache.kafka.common.serialization.StringSerializer");
>     props.put("max.block.ms", 10000); // 10 seconds should illustrate our point
>     String separator = "/";
>     //String separator = "_";
>     try (Producer<String, String> producer = new KafkaProducer<>(props)) {
>       System.out.println("Calling KafkaProducer.send() at " + new Date());
>       producer.send(
>           new ProducerRecord<String, String>("abc" + separator + "someStreamName",
>               "Not expecting a TimeoutException here"),
>           new Callback() {
>             @Override
>             public void onCompletion(RecordMetadata metadata, Exception e) {
>               if (e != null) {
>                 System.out.println(e.toString());
>               }
>             }
>           });
>       System.out.println("KafkaProducer.send() completed at " + new Date());
>     }
>   }
> }
> {code}
> Switching to the underscore separator in the above example works as expected.
> Mea culpa: We neglected to research allowed chars in a topic name, but the TimeoutException we encountered did not help point us in the right direction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)