You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/01 11:29:50 UTC
[GitHub] [spark] sarutak opened a new pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
sarutak opened a new pull request #28694:
URL: https://github.com/apache/spark/pull/28694
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fixes a wrong coloring issue in the DAG-viz.
In the Job Page and Stage Page, nodes which are associated with "barrier mode" in the DAG-viz will be colored pale green.
But, with some type of jobs, nodes which are not associated with the mode will also colored.
You can reproduce with the following operation.
```
sc.parallelize(1 to 10).barrier.mapPartitions(identity).repartition(1).collect()
```
<img width="376" alt="wrong-coloring" src="https://user-images.githubusercontent.com/4736016/83403670-1711df00-a444-11ea-9457-c683f75bc566.png">
In the screen shot above, `repartition` in `Stage 1` is not associated with barrier mode so the corresponding node should not be colored pale green.
The cause of this issue is the logic which chooses HTML elements to be colored is wrong.
The logic chooses such elements based on whether each element is associated with a style class (`clusterId` in the code).
But when an operation crosses over shuffle (like `repartition` above), a `clusterId` can be duplicated and non-barrier mode node is also associated with the same `clusterId`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This is a bug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Newly added test case with the following command.
```
build/sbt -Dtest.default.exclude.tags= -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver "testOnly org.apache.spark.ui.ChromeUISeleniumSuite -- -z SPARK-31886"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636895645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636805044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636895645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636804406
**[Test build #123372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123372/testReport)** for PR 28694 at commit [`8f6d2a7`](https://github.com/apache/spark/commit/8f6d2a725a42f35bcaaa09588ceb879af0253d78).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637878952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636833977
**[Test build #123374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123374/testReport)** for PR 28694 at commit [`e2aec91`](https://github.com/apache/spark/commit/e2aec917a9e7e5c711dfb7605bafb495159c08d6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636804406
**[Test build #123372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123372/testReport)** for PR 28694 at commit [`8f6d2a7`](https://github.com/apache/spark/commit/8f6d2a725a42f35bcaaa09588ceb879af0253d78).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28694:
URL: https://github.com/apache/spark/pull/28694#discussion_r433203768
##########
File path: core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala
##########
@@ -78,6 +78,35 @@ abstract class RealBrowserUISeleniumSuite(val driverProp: String)
}
}
+
Review comment:
Ah, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-638038924
Thanks, merging to master/3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #28694:
URL: https://github.com/apache/spark/pull/28694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637921910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] DylanGuedes commented on a change in pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
DylanGuedes commented on a change in pull request #28694:
URL: https://github.com/apache/spark/pull/28694#discussion_r433200220
##########
File path: core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala
##########
@@ -78,6 +78,35 @@ abstract class RealBrowserUISeleniumSuite(val driverProp: String)
}
}
+
Review comment:
nit: extra line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636894399
**[Test build #123372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123372/testReport)** for PR 28694 at commit [`8f6d2a7`](https://github.com/apache/spark/commit/8f6d2a725a42f35bcaaa09588ceb879af0253d78).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636833977
**[Test build #123374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123374/testReport)** for PR 28694 at commit [`e2aec91`](https://github.com/apache/spark/commit/e2aec917a9e7e5c711dfb7605bafb495159c08d6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637878952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28694:
URL: https://github.com/apache/spark/pull/28694#discussion_r433203768
##########
File path: core/src/test/scala/org/apache/spark/ui/RealBrowserUISeleniumSuite.scala
##########
@@ -78,6 +78,35 @@ abstract class RealBrowserUISeleniumSuite(val driverProp: String)
}
}
+
Review comment:
Ah, Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637921256
**[Test build #123451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123451/testReport)** for PR 28694 at commit [`88edc95`](https://github.com/apache/spark/commit/88edc9520c9988ae613612168084e76a25fa98c6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class ExecutorResourceRequest(`
* `class ExecutorResourceRequests() extends Serializable `
* `class ResourceProfileBuilder() `
* `class TaskResourceRequest(val resourceName: String, val amount: Double)`
* `class TaskResourceRequests() extends Serializable `
* `case class CheckOverflowInSum(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636919073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637878649
**[Test build #123451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123451/testReport)** for PR 28694 at commit [`88edc95`](https://github.com/apache/spark/commit/88edc9520c9988ae613612168084e76a25fa98c6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637878649
**[Test build #123451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123451/testReport)** for PR 28694 at commit [`88edc95`](https://github.com/apache/spark/commit/88edc9520c9988ae613612168084e76a25fa98c6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637921910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636917924
**[Test build #123374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123374/testReport)** for PR 28694 at commit [`e2aec91`](https://github.com/apache/spark/commit/e2aec917a9e7e5c711dfb7605bafb495159c08d6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636834566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636834566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636805044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-637214550
cc @gengliangwang FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28694: [SPARK-31886][WEBUI] Fix the wrong coloring of nodes in DAG-viz
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28694:
URL: https://github.com/apache/spark/pull/28694#issuecomment-636919073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org