You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/07 21:32:13 UTC

[GitHub] [airflow] JGoldman110 opened a new pull request, #28788: Remove swagger-ui extra from connexion to resolve CVE-2019-17495

JGoldman110 opened a new pull request, #28788:
URL: https://github.com/apache/airflow/pull/28788

   install `swagger-ui-dist` via npm package rather then install installing `swagger-ui-bundle` from `connexion[swagger-ui]` extra which contains version 2.2.10 which is vulnerable to CVE-2019-17495.
   
   closes: #28381 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28788: Remove swagger-ui extra from connexion to resolve CVE-2019-17495

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28788:
URL: https://github.com/apache/airflow/pull/28788#issuecomment-1374619547

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #28788: Remove swagger-ui extra from connexion to resolve CVE-2019-17495

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28788:
URL: https://github.com/apache/airflow/pull/28788#issuecomment-1374665671

   Thanks @JGoldman110 for that one. @mik-laj @ephraimbuddy  - I tested this one and it looks cool, do you think there are any potential problems if we do to it this way?
   
   Screenshot from airflow built using this PR:
   
   <img width="1886" alt="Screenshot 2023-01-08 at 01 14 21" src="https://user-images.githubusercontent.com/595491/211175012-93a0f84d-60ff-4fc9-92df-6f4a0c91c9b0.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #28788: Remove swagger-ui extra from connexion to resolve CVE-2019-17495

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28788:
URL: https://github.com/apache/airflow/pull/28788


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28788: Remove swagger-ui extra from connexion to resolve CVE-2019-17495

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28788:
URL: https://github.com/apache/airflow/pull/28788#issuecomment-1377035855

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org