You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "chia7712 (via GitHub)" <gi...@apache.org> on 2024/12/01 03:52:52 UTC
Re: [PR] KAFKA-18124: Remove zk migration from `RaftManagerTest`, `BrokerLifecycleManagerTest`, `KafkaConfigTest`, and `ReplicaManagerTest` [kafka]
chia7712 commented on code in PR #17990:
URL: https://github.com/apache/kafka/pull/17990#discussion_r1864723322
##########
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##########
@@ -113,10 +111,9 @@ class BrokerLifecycleManagerTest {
}
}
- @ParameterizedTest
- @ValueSource(booleans = Array(true, false))
- def testSuccessfulRegistrationDuringMigration(nonInitialKraftVersion: Boolean): Unit = {
- val ibp = if (nonInitialKraftVersion) IBP_3_9_IV0 else IBP_3_8_IV0
+ @Test
+ def testSuccessfulRegistrationDuringMigration(): Unit = {
Review Comment:
The migration will be removed so we don't need this test case , right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org