You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "xuruidong (via GitHub)" <gi...@apache.org> on 2023/06/12 14:10:00 UTC
[GitHub] [apisix] xuruidong opened a new pull request, #9646: docs: fix broken link
xuruidong opened a new pull request, #9646:
URL: https://github.com/apache/apisix/pull/9646
### Description
fix a link in https://apisix.apache.org/zh/docs/apisix/terminology/plugin/


Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] guoqqqi commented on a diff in pull request #9646: docs: fix broken link
Posted by "guoqqqi (via GitHub)" <gi...@apache.org>.
guoqqqi commented on code in PR #9646:
URL: https://github.com/apache/apisix/pull/9646#discussion_r1230315950
##########
docs/zh/latest/terminology/plugin.md:
##########
@@ -284,6 +284,6 @@ curl http://127.0.0.1:9180/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034
:::
-## stand-alone 模式下的热加载
+## Standalone 模式下的热加载
-关于 Stand Alone 模式下的热加载的信息,请参考 [stand alone 模式](../stand-alone.md)。
+关于 Stand Alone 模式下的热加载的信息,请参考 [stand alone 模式](../../../en/latest/deployment-modes.md#standalone)。
Review Comment:
In my opinion, we should not redirect this link to the English directory even though the Chinese documentation has not been translated into Chinese.
`https://apisix.apache.org/zh/docs/apisix/deployment-modes/#standalone`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9646: docs: fix broken link
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9646:
URL: https://github.com/apache/apisix/pull/9646#discussion_r1230320842
##########
docs/zh/latest/terminology/plugin.md:
##########
@@ -284,6 +284,6 @@ curl http://127.0.0.1:9180/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034
:::
-## stand-alone 模式下的热加载
+## Standalone 模式下的热加载
-关于 Stand Alone 模式下的热加载的信息,请参考 [stand alone 模式](../stand-alone.md)。
+关于 Stand Alone 模式下的热加载的信息,请参考 [stand alone 模式](../../../en/latest/deployment-modes.md#standalone)。
Review Comment:
Why? The current page is missing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] guoqqqi commented on a diff in pull request #9646: docs: fix broken link
Posted by "guoqqqi (via GitHub)" <gi...@apache.org>.
guoqqqi commented on code in PR #9646:
URL: https://github.com/apache/apisix/pull/9646#discussion_r1230328375
##########
docs/zh/latest/terminology/plugin.md:
##########
@@ -284,6 +284,6 @@ curl http://127.0.0.1:9180/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034
:::
-## stand-alone 模式下的热加载
+## Standalone 模式下的热加载
-关于 Stand Alone 模式下的热加载的信息,请参考 [stand alone 模式](../stand-alone.md)。
+关于 Stand Alone 模式下的热加载的信息,请参考 [stand alone 模式](../../../en/latest/deployment-modes.md#standalone)。
Review Comment:
Sorry, I was wrong, I thought we already had a Chinese document that was not fully translated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] guoqqqi merged pull request #9646: docs: fix broken link
Posted by "guoqqqi (via GitHub)" <gi...@apache.org>.
guoqqqi merged PR #9646:
URL: https://github.com/apache/apisix/pull/9646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org