You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2013/11/07 21:50:08 UTC

svn commit: r1539811 - /wicket/common/site/trunk/_site/start/quickstart.html

Author: adelbene
Date: Thu Nov  7 20:50:08 2013
New Revision: 1539811

URL: http://svn.apache.org/r1539811
Log:
Fixed quickstart.html

Modified:
    wicket/common/site/trunk/_site/start/quickstart.html

Modified: wicket/common/site/trunk/_site/start/quickstart.html
URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/start/quickstart.html?rev=1539811&r1=1539810&r2=1539811&view=diff
==============================================================================
--- wicket/common/site/trunk/_site/start/quickstart.html (original)
+++ wicket/common/site/trunk/_site/start/quickstart.html Thu Nov  7 20:50:08 2013
@@ -184,7 +184,7 @@
 <h2 id="creating_the_project__with_maven">Creating the project - with Maven</h2>
 
 <p>To create your project, copy and paste the command line generated after typing in the groupId, artifactId and version.</p>
-<style><![CDATA[	
+<style>	
 	#mvncmd {
 		padding-left: 25px;
 	}
@@ -197,7 +197,7 @@
 	#mvncmd textarea { width: 400px; height: 100px; }
 	#mvncmd br { clear: left; }	
 	#mvncmd div { clear:both; padding-left: 25px; vertical-align:top;}
-]]></style><script type='text/javascript'><![CDATA[
+</style><script type='text/javascript'>
 	function changeIt()
 	{
 		var groupId = document.getElementById("groupId").value;
@@ -216,7 +216,7 @@
 		cmd += ' -DinteractiveMode=false'; 
 		document.getElementById("cmdLine").value = cmd;
 	}
-]]></script><div id='mvncmd'>
+</script><div id='mvncmd'>
 	<div>
 		<label for='groupId' title='Base Package'>GroupId:</label>
 		<input id='groupId' onkeyup='changeIt();' type='text' value='com.mycompany' /><span title='Base Package'>&nbsp;(?)</span><br />
@@ -259,7 +259,7 @@
 		<label for='cmdLine' id='cmdLabel'>Command Line:</label>
 		<textarea id='cmdLine' onfocus='this.select();'>
 		</textarea>
-		<script><![CDATA[changeIt();]]></script>
+		<script>changeIt();</script>
 	</div>
 	<br />
 </div>



Re: svn commit: r1539811 - /wicket/common/site/trunk/_site/start/quickstart.html

Posted by Sven Meier <sv...@meiers.net>.
>This markup will be overwritten next time by the site generator

Only with your version of Jekyll - 0.12.1 on Ubuntu works fine.

Regards
Sven



On 11/08/2013 12:41 AM, Martijn Dashorst wrote:
> Andrea,
>
> This markup will be overwritten next time by the site generator. The
> short term fix is correct, as this will fix the site, but next time
> someone updates the site, it will have the offending markup again.
>
> A short search suggest that
> https://github.com/mojombo/jekyll/pull/1672 caused the CDATA sections
> to arrive in the markup.
>
> Martijn
>
>
> On Thu, Nov 7, 2013 at 9:50 PM,  <ad...@apache.org> wrote:
>> Author: adelbene
>> Date: Thu Nov  7 20:50:08 2013
>> New Revision: 1539811
>>
>> URL: http://svn.apache.org/r1539811
>> Log:
>> Fixed quickstart.html
>>
>> Modified:
>>      wicket/common/site/trunk/_site/start/quickstart.html
>>
>> Modified: wicket/common/site/trunk/_site/start/quickstart.html
>> URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/start/quickstart.html?rev=1539811&r1=1539810&r2=1539811&view=diff
>> ==============================================================================
>> --- wicket/common/site/trunk/_site/start/quickstart.html (original)
>> +++ wicket/common/site/trunk/_site/start/quickstart.html Thu Nov  7 20:50:08 2013
>> @@ -184,7 +184,7 @@
>>   <h2 id="creating_the_project__with_maven">Creating the project - with Maven</h2>
>>
>>   <p>To create your project, copy and paste the command line generated after typing in the groupId, artifactId and version.</p>
>> -<style><![CDATA[
>> +<style>
>>          #mvncmd {
>>                  padding-left: 25px;
>>          }
>> @@ -197,7 +197,7 @@
>>          #mvncmd textarea { width: 400px; height: 100px; }
>>          #mvncmd br { clear: left; }
>>          #mvncmd div { clear:both; padding-left: 25px; vertical-align:top;}
>> -]]></style><script type='text/javascript'><![CDATA[
>> +</style><script type='text/javascript'>
>>          function changeIt()
>>          {
>>                  var groupId = document.getElementById("groupId").value;
>> @@ -216,7 +216,7 @@
>>                  cmd += ' -DinteractiveMode=false';
>>                  document.getElementById("cmdLine").value = cmd;
>>          }
>> -]]></script><div id='mvncmd'>
>> +</script><div id='mvncmd'>
>>          <div>
>>                  <label for='groupId' title='Base Package'>GroupId:</label>
>>                  <input id='groupId' onkeyup='changeIt();' type='text' value='com.mycompany' /><span title='Base Package'>&nbsp;(?)</span><br />
>> @@ -259,7 +259,7 @@
>>                  <label for='cmdLine' id='cmdLabel'>Command Line:</label>
>>                  <textarea id='cmdLine' onfocus='this.select();'>
>>                  </textarea>
>> -               <script><![CDATA[changeIt();]]></script>
>> +               <script>changeIt();</script>
>>          </div>
>>          <br />
>>   </div>
>>
>>
>
>


Re: svn commit: r1539811 - /wicket/common/site/trunk/_site/start/quickstart.html

Posted by Martijn Dashorst <ma...@gmail.com>.
Andrea,

This markup will be overwritten next time by the site generator. The
short term fix is correct, as this will fix the site, but next time
someone updates the site, it will have the offending markup again.

A short search suggest that
https://github.com/mojombo/jekyll/pull/1672 caused the CDATA sections
to arrive in the markup.

Martijn


On Thu, Nov 7, 2013 at 9:50 PM,  <ad...@apache.org> wrote:
> Author: adelbene
> Date: Thu Nov  7 20:50:08 2013
> New Revision: 1539811
>
> URL: http://svn.apache.org/r1539811
> Log:
> Fixed quickstart.html
>
> Modified:
>     wicket/common/site/trunk/_site/start/quickstart.html
>
> Modified: wicket/common/site/trunk/_site/start/quickstart.html
> URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/start/quickstart.html?rev=1539811&r1=1539810&r2=1539811&view=diff
> ==============================================================================
> --- wicket/common/site/trunk/_site/start/quickstart.html (original)
> +++ wicket/common/site/trunk/_site/start/quickstart.html Thu Nov  7 20:50:08 2013
> @@ -184,7 +184,7 @@
>  <h2 id="creating_the_project__with_maven">Creating the project - with Maven</h2>
>
>  <p>To create your project, copy and paste the command line generated after typing in the groupId, artifactId and version.</p>
> -<style><![CDATA[
> +<style>
>         #mvncmd {
>                 padding-left: 25px;
>         }
> @@ -197,7 +197,7 @@
>         #mvncmd textarea { width: 400px; height: 100px; }
>         #mvncmd br { clear: left; }
>         #mvncmd div { clear:both; padding-left: 25px; vertical-align:top;}
> -]]></style><script type='text/javascript'><![CDATA[
> +</style><script type='text/javascript'>
>         function changeIt()
>         {
>                 var groupId = document.getElementById("groupId").value;
> @@ -216,7 +216,7 @@
>                 cmd += ' -DinteractiveMode=false';
>                 document.getElementById("cmdLine").value = cmd;
>         }
> -]]></script><div id='mvncmd'>
> +</script><div id='mvncmd'>
>         <div>
>                 <label for='groupId' title='Base Package'>GroupId:</label>
>                 <input id='groupId' onkeyup='changeIt();' type='text' value='com.mycompany' /><span title='Base Package'>&nbsp;(?)</span><br />
> @@ -259,7 +259,7 @@
>                 <label for='cmdLine' id='cmdLabel'>Command Line:</label>
>                 <textarea id='cmdLine' onfocus='this.select();'>
>                 </textarea>
> -               <script><![CDATA[changeIt();]]></script>
> +               <script>changeIt();</script>
>         </div>
>         <br />
>  </div>
>
>



-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com