[GitHub] [tomcat] markt-asf commented on issue #143: Apply deduplication to certain loaded and created Strings

[GitBox <gi...@apache.org>]

markt-asf commented on issue #143: Apply deduplication to certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470662734
 
 
   I've been running YourKit with allocation tracking enabled and tracking each of the duplicated strings to the root cause. I started with the biggest duplicates and stopped somewhere around 700 bytes / per duplicated String. I ended up with a slightly different patch that covers the same duplicates and a few more. Start-up time appears to remain unaffected. Total saving ~245k.
   
   I'm going to close this PR but I'll credit you in the commit message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org