You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kurt Deschler (Code Review)" <ge...@cloudera.org> on 2023/05/15 20:28:55 UTC

[Impala-ASF-CR] IMPALA-11068: Add tuning flag to reduce scanner thread launch.

Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 )

Change subject: IMPALA-11068: Add tuning flag to reduce scanner thread launch.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18126/1/be/src/runtime/scanner-mem-limiter.cc
File be/src/runtime/scanner-mem-limiter.cc:

http://gerrit.cloudera.org:8080/#/c/18126/1/be/src/runtime/scanner-mem-limiter.cc@28
PS1, Line 28:     "Number of thread headroom where we decide to stop launching new thread. "
This kind of indirect limit can be hard to understand and tune. Is there something we can do more direct to bound memory better such as reduce row batch sizes?



-- 
To view, visit http://gerrit.cloudera.org:8080/18126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03cadf1230eed00d69f2890c82476c6861e37466
Gerrit-Change-Number: 18126
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 20:28:55 +0000
Gerrit-HasComments: Yes