You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2025/04/30 08:40:52 UTC
(doris) branch vector-index-dev updated: [fix](vector) should retain all virtual columns (#50571)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch vector-index-dev
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/vector-index-dev by this push:
new 82b7c5d300e [fix](vector) should retain all virtual columns (#50571)
82b7c5d300e is described below
commit 82b7c5d300ede2c005f549c9762e195ece480b9c
Author: morrySnow <zh...@selectdb.com>
AuthorDate: Wed Apr 30 16:40:44 2025 +0800
[fix](vector) should retain all virtual columns (#50571)
---
.../nereids/glue/translator/PhysicalPlanTranslator.java | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
index 847300d1933..bd6248ffe9e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
@@ -2542,11 +2542,7 @@ public class PhysicalPlanTranslator extends DefaultPlanVisitor<PlanFragment, Pla
.map(s -> (SlotRef) s)
.map(SlotRef::getSlotId)
.collect(Collectors.toSet());
- for (SlotDescriptor slot : scanNode.getTupleDesc().getSlots()) {
- if (virtualColumnInputSlotIds.contains(slot.getId()) && slot.getColumn() != null) {
- requiredWithVirtualColumns.add(slot.getId());
- }
- }
+ requiredWithVirtualColumns.addAll(virtualColumnInputSlotIds);
}
// TODO: use smallest slot if do not need any slot in upper node
SlotDescriptor smallest = scanNode.getTupleDesc().getSlots().get(0);
@@ -2585,16 +2581,6 @@ public class PhysicalPlanTranslator extends DefaultPlanVisitor<PlanFragment, Pla
return tupleDescriptor;
}
- private TupleDescriptor generateTupleDescWithVirtualColumns(List<Slot> slotList, List<Expression> virtualColumns,
- TableIf table, PlanTranslatorContext context) {
- TupleDescriptor tupleDescriptor = context.generateTupleDesc();
- tupleDescriptor.setTable(table);
- for (Slot slot : slotList) {
- context.createSlotDesc(tupleDescriptor, (SlotReference) slot, table);
- }
- return tupleDescriptor;
- }
-
private PlanFragment connectJoinNode(HashJoinNode hashJoinNode, PlanFragment leftFragment,
PlanFragment rightFragment, PlanTranslatorContext context, AbstractPlan join) {
hashJoinNode.setChild(0, leftFragment.getPlanRoot());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org