You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/06 17:38:18 UTC

[GitHub] [flink-docker] zentol commented on a change in pull request #20: [FLINK-17164] Add job-cluster support

zentol commented on a change in pull request #20:
URL: https://github.com/apache/flink-docker/pull/20#discussion_r420971244



##########
File path: testing/run_travis_tests.sh
##########
@@ -11,14 +11,6 @@ fi
 
 BRANCH="$TRAVIS_BRANCH"
 
-if [ -n "$IS_PULL_REQUEST" ]; then
-  changed_files="$(git diff --name-only $BRANCH...HEAD)"

Review comment:
       You can't do a diff against an arbitrary branch right after a clone; we'd first need to fetch other branches which I tried but the damn thing still wasn't working.
   
   So I deleted it because this is not something I want to spend time on.
   Note that this also applies to the other dev branches.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org